Skip to content

Kokkos UserObjects and Postprocessors System #31858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: next
Choose a base branch
from
Draft

Kokkos UserObjects and Postprocessors System #31858

wants to merge 14 commits into from
+6,321 −443

Conversation

@NamjaeChoi
Copy link
Contributor

@NamjaeChoi NamjaeChoi commented Nov 6, 2025 •
edited
Loading

Refs #30655.

@NamjaeChoi NamjaeChoi changed the title Kokkos UserObjects and Postprocessors System WIP: Kokkos UserObjects and Postprocessors System Nov 6, 2025
@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch 2 times, most recently from 81a8706 to 0d85639 Compare November 6, 2025 21:08
@NamjaeChoi NamjaeChoi moved this to In progress in NEAMS MP CONNECT/GPU 26 Nov 6, 2025
@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch 5 times, most recently from fed2f32 to 865bc8f Compare November 9, 2025 02:01
@NamjaeChoi NamjaeChoi changed the title WIP: Kokkos UserObjects and Postprocessors System Kokkos UserObjects and Postprocessors System Nov 9, 2025
@NamjaeChoi NamjaeChoi changed the title Kokkos UserObjects and Postprocessors System WIP: Kokkos UserObjects and Postprocessors System Nov 9, 2025
@NamjaeChoi NamjaeChoi changed the title WIP: Kokkos UserObjects and Postprocessors System Kokkos UserObjects and Postprocessors System Nov 9, 2025
@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch from 865bc8f to f40d392 Compare November 9, 2025 03:44
@NamjaeChoi NamjaeChoi changed the title Kokkos UserObjects and Postprocessors System WIP: Kokkos UserObjects and Postprocessors System Nov 9, 2025
@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch from f40d392 to abf345d Compare November 9, 2025 06:03
@moosebuild
Copy link
Contributor

moosebuild commented Nov 9, 2025 •
edited
Loading

Job Documentation, step Docs: sync website on 4c7f682 wanted to post the following:

View the site here

This comment will be updated on new commits.

@NamjaeChoi NamjaeChoi changed the title WIP: Kokkos UserObjects and Postprocessors System Kokkos UserObjects and Postprocessors System Nov 9, 2025
@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch 2 times, most recently from b9c0c72 to 9a79327 Compare November 9, 2025 06:20
@moosebuild
Copy link
Contributor

moosebuild commented Nov 9, 2025 •
edited
Loading

Job Coverage, step Generate coverage on 4c7f682 wanted to post the following:

Framework coverage

b79a48 #31858 4c7f68
Total Total +/- New
Rate 85.97% 85.99% +0.02% 100.00%
Hits 125127 125807 +680 902
Misses 20418 20503 +85 0

Diff coverage report

Full coverage report

Modules coverage

Stochastic tools

b79a48 #31858 4c7f68
Total Total +/- New
Rate 90.83% 90.83% +0.00% -
Hits 8198 8199 +1 0
Misses 828 828 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch 2 times, most recently from 2fc86e1 to 856996b Compare November 10, 2025 21:24
@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch 4 times, most recently from f9f86f6 to 7514801 Compare November 12, 2025 00:24
@NamjaeChoi NamjaeChoi mentioned this pull request Nov 12, 2025
Draft
NamjaeChoi
NamjaeChoi commented Nov 12, 2025
View reviewed changes
framework/include/kokkos/base/KokkosUtils.h

for (unsigned int j = i + 1; j < n; ++j)
sum -= A[i + n * j] * b[j];
sum -= A[i + n * j] * x[j];
Copy link
Contributor Author

@NamjaeChoi NamjaeChoi Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must be drunk when implementing this. And I have no idea why this worked with the element auxkernels tested thus far.

@NamjaeChoi
Copy link
Contributor Author

NamjaeChoi commented Nov 12, 2025 •
edited
Loading

@lindsayad The code is pretty much ready for review. I need to add some docstrings/documents. Also looking for some good UserObject tests. UserObjects are really exotic and not easy to find something that can be easily ported except for some dummy test objects.

@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch 3 times, most recently from 949ae89 to 3cf53f9 Compare November 13, 2025 02:49
@moosebuild
Copy link
Contributor

moosebuild commented Nov 13, 2025

Job Precheck, step Clang format on 3cf53f9 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31858/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 70199315b038d48040575dcc5f76966c49253221

@NamjaeChoi NamjaeChoi force-pushed the kokkos_postprocessor branch 2 times, most recently from f286da7 to 195b04d Compare November 13, 2025 04:09
@moosebuild
Copy link
Contributor

moosebuild commented Nov 13, 2025

Job Test, step Results summary on 4c7f682 wanted to post the following:

Framework test summary

Compared against b79a48d in job civet.inl.gov/job/3380566.

Added tests

Test Time (s)
kokkos/postprocessors/nodal_extreme_value.nodal_max/whole_domain 2.18
kokkos/postprocessors/nodal_extreme_value.nodal_extreme/value 1.33
kokkos/postprocessors/nodal_extreme_value.nodal_extreme/proxy 1.01
kokkos/postprocessors/element_extreme_value.elemental_extreme/proxy 1.00
kokkos/postprocessors/nodal_sum.nodal_sum/nodal_sum_block_non_unique 0.98
kokkos/postprocessors/element_integral_material_property.average 0.97
kokkos/postprocessors/nodal_extreme_value.nodal_max/block_restricted 0.96
kokkos/postprocessors/side_extreme_value.side_extreme/aux_elemental 0.96
kokkos/postprocessors/element_integral.element_integral/abs_test 0.96
kokkos/postprocessors/side_extreme_value.side_extreme/nonlinear_variable_proxy 0.95
kokkos/postprocessors/nodal_sum.nodal_sum/nodal_sum_block 0.94
kokkos/postprocessors/side_integral.side_average/variable 0.94
kokkos/postprocessors/nodal_l2_norm.nodal_l2_norm 0.94
kokkos/postprocessors/element_integral.element_average 0.92
kokkos/postprocessors/side_integral.side_integral/material_property 0.92
kokkos/postprocessors/side_extreme_value.side_extreme/aux_nodal 0.92
kokkos/postprocessors/element_integral.element_integral/block_test 0.91
kokkos/postprocessors/element_l2_norm.test 0.91
kokkos/postprocessors/element_integral_material_property.integral 0.88
kokkos/postprocessors/side_integral.side_integral/variable 0.88
kokkos/postprocessors/side_integral.side_average/material_property 0.88
kokkos/postprocessors/element_extreme_value.elemental_extreme/value 0.85
kokkos/postprocessors/nodal_sum.nodal_sum/all 0.83
kokkos/postprocessors/side_extreme_value.side_extreme/nonlinear_variable 0.83
kokkos/postprocessors/element_integral.element_integral/test 0.74

Modules test summary

Compared against b79a48d in job civet.inl.gov/job/3380566.

No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad will be requested when the pull request is marked ready for review lindsayad is a code owner

@joshuahansel joshuahansel Awaiting requested review from joshuahansel joshuahansel will be requested when the pull request is marked ready for review joshuahansel is a code owner

@zachmprince zachmprince Awaiting requested review from zachmprince zachmprince will be requested when the pull request is marked ready for review zachmprince is a code owner

@loganharbour loganharbour Awaiting requested review from loganharbour loganharbour will be requested when the pull request is marked ready for review loganharbour is a code owner

@GiudGiud GiudGiud Awaiting requested review from GiudGiud GiudGiud will be requested when the pull request is marked ready for review GiudGiud is a code owner

@roystgnr roystgnr Awaiting requested review from roystgnr roystgnr will be requested when the pull request is marked ready for review roystgnr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@lindsayad lindsayad

Labels

None yet

Projects

NEAMS MP CONNECT/GPU 26
Status: In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NamjaeChoi @moosebuild @lindsayad