-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[WIP] Dome natural convection #31861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lindsayad
wants to merge
33
commits into
idaholab:next
Choose a base branch
from
lindsayad:dome-natural-convection
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,218
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Code changes are fine here but the case might fit better in OpenPronghorn? |
Contributor
|
This is just a WIP branch dedicated to sharing some models with some collaborators. |
0272308 to
7313821
Compare
Also using upwind interpolation for the advection term Most troubling part of the results is that the peak magnitude of the velocity is at the top of the hot experiment pointing directly into the boundary. There is also some checkerboarding in the fluid temperature in that same single cell layer above the hot experiment
0b912df to
d6dd07a
Compare
…doesn't conflict with the inlets and outlet sidesets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Design
Impact