Add coordinate transform factor to RC body force correction. #31863
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Job Test, step Results summary on 9c36dd8 wanted to post the following: Framework test summaryCompared against 7323e92 in job civet.inl.gov/job/3361666. Removed testsAdded testsRun time changesModules test summaryCompared against 7323e92 in job civet.inl.gov/job/3361666. Removed testsAdded testsRun time changes |
GiudGiud
approved these changes
Nov 7, 2025
Contributor
|
Job Documentation, step Docs: sync website on 9c36dd8 wanted to post the following: View the site here This comment will be updated on new commits. |
lindsayad
approved these changes
Nov 7, 2025
Member
lindsayad
left a comment
lindsayad
left a comment
There was a problem hiding this comment.
Would be good to test to make sure we don't regress
Contributor
Author
|
I'll add a test in a bit! |
Contributor
Author
|
Oh wait, we will need this first for a test first: |
Member
|
That PR is in now (as you know 😄 ) |
Contributor
Author
|
Yeah I am working on an MMS case for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31862