Skip to content

Conversation

@GiudGiud
Copy link
Contributor

should be a decent start
refs #31887

@GiudGiud GiudGiud self-assigned this Nov 10, 2025
@GiudGiud GiudGiud marked this pull request as ready for review November 10, 2025 20:27
@moosebuild
Copy link
Contributor

moosebuild commented Nov 10, 2025

Job Documentation, step Docs: sync website on 7da9e88 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Documentation on e458713 : invalidated by @GiudGiud

random fail


!table id=navier_stokes_summary caption=Summary of Navier-Stokes implementations
| prefix | Jacobian | compressibility | turbulence support | friction support | method | advection strategy |
| prefix | Jacobian | compressibility | turbulence support | friction support | discretiz. | advection strategy |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be more accurate/clearer to introduce an additional column called "solver" and then discretization would remain just "FV" for the linear FV implementation and solver would be "SIMPLE/PIMPLE"

Copy link
Contributor Author

@GiudGiud GiudGiud Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linearFV is kind of different though, not just the solver? like the base classes for the variables are similar but different
like some items that are "discretization"-related such as "two term expansions" are decided in a different place (variables & kernels) in nonlinearFV and linearFV

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are implementation details that are not relevant to a user. Real differences are things like lagging certain quantities in order to keep them linear. I don't know if that is really a difference in the spatial discretization though. More like a state difference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well we do lag a ton more in linearFV than in Newton. In fact we try not to lag anything in Newton

Copy link
Contributor Author

@GiudGiud GiudGiud Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that's all tied to the solver / discretization in time rather than in space

the gradients are lagged in linearFV and not FV that's a space-time discretization that is different

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well we do lag a ton more in linearFV than in Newton. In fact we try not to lag anything in Newton

I know that. That's why I said

Real differences are things like lagging certain quantities in order to keep them linear.

I wrote a very large share of the Newton code. I know how it works.

but that's all tied to the solver / discretization in time rather than in space

Agreed. That's why I said

I don't know if that is really a difference in the spatial discretization though. More like a state difference

If the spatial locations used to evaluate things like a Green-Gauss gradient or the non-orthogonal gradient are the same, then I believe the spatial discretization is the same. If the only difference is that you're indexing into different vectors (states), I don't think that equates to a difference in spatial discretization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iterative two term expansions are something that are unique to FV.
It is tied to not wanting to lag though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the spatial locations used to evaluate things like a Green-Gauss gradient or the non-orthogonal gradient are the same, then I believe the spatial discretization is the same.

@grmnptr any differences on that aspect?

- accept all suggestions on wording and precisions

Co-authored-by: Alex Lindsay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants