-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add a dedicated linear WCNSFV page with links to the relevant sections in linearFV, NS and physics #31888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
c1a2dbd to
31d9fe5
Compare
|
Job Documentation, step Docs: sync website on 7da9e88 wanted to post the following: View the site here This comment will be updated on new commits. |
…s in linearFV, NS and physics refs idaholab#31887
31d9fe5 to
e458713
Compare
|
Job Documentation on e458713 : invalidated by @GiudGiud random fail |
modules/navier_stokes/doc/content/modules/navier_stokes/linear_wcnsfv.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/linear_wcnsfv.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/index.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/index.md
Outdated
Show resolved
Hide resolved
|
|
||
| !table id=navier_stokes_summary caption=Summary of Navier-Stokes implementations | ||
| | prefix | Jacobian | compressibility | turbulence support | friction support | method | advection strategy | | ||
| | prefix | Jacobian | compressibility | turbulence support | friction support | discretiz. | advection strategy | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be more accurate/clearer to introduce an additional column called "solver" and then discretization would remain just "FV" for the linear FV implementation and solver would be "SIMPLE/PIMPLE"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linearFV is kind of different though, not just the solver? like the base classes for the variables are similar but different
like some items that are "discretization"-related such as "two term expansions" are decided in a different place (variables & kernels) in nonlinearFV and linearFV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are implementation details that are not relevant to a user. Real differences are things like lagging certain quantities in order to keep them linear. I don't know if that is really a difference in the spatial discretization though. More like a state difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well we do lag a ton more in linearFV than in Newton. In fact we try not to lag anything in Newton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but that's all tied to the solver / discretization in time rather than in space
the gradients are lagged in linearFV and not FV that's a space-time discretization that is different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well we do lag a ton more in linearFV than in Newton. In fact we try not to lag anything in Newton
I know that. That's why I said
Real differences are things like lagging certain quantities in order to keep them linear.
I wrote a very large share of the Newton code. I know how it works.
but that's all tied to the solver / discretization in time rather than in space
Agreed. That's why I said
I don't know if that is really a difference in the spatial discretization though. More like a state difference
If the spatial locations used to evaluate things like a Green-Gauss gradient or the non-orthogonal gradient are the same, then I believe the spatial discretization is the same. If the only difference is that you're indexing into different vectors (states), I don't think that equates to a difference in spatial discretization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The iterative two term expansions are something that are unique to FV.
It is tied to not wanting to lag though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the spatial locations used to evaluate things like a Green-Gauss gradient or the non-orthogonal gradient are the same, then I believe the spatial discretization is the same.
@grmnptr any differences on that aspect?
modules/navier_stokes/doc/content/modules/navier_stokes/index.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/linear_wcnsfv.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/linear_wcnsfv.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/linear_wcnsfv.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/linear_wcnsfv.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/linear_wcnsfv.md
Outdated
Show resolved
Hide resolved
modules/navier_stokes/doc/content/modules/navier_stokes/linear_wcnsfv.md
Outdated
Show resolved
Hide resolved
- accept all suggestions on wording and precisions Co-authored-by: Alex Lindsay <[email protected]>
should be a decent start
refs #31887