Skip to content

Conversation

@joshuahansel
Copy link
Contributor

Added options to FlowChannel1Phase for outputting quantities via VPPs:

  • vpp_vars: Creates an ElementValueSampler with a vector for each of the listed variables
  • create_flux_vpp: Creates a NumericalFlux3EqnInternalValues, which creates a vector for each numerical flux component (mass, momentum, energy) at the internal sides

Closes #31891

@joshuahansel joshuahansel requested a review from grmnptr November 11, 2025 15:22
@joshuahansel joshuahansel self-assigned this Nov 11, 2025
@joshuahansel joshuahansel force-pushed the numerical-flux-vpp branch 2 times, most recently from d06848b to ecb2cde Compare November 11, 2025 16:52
@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on ecb2cde wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31892/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 7edd10c4e1e441b808e9c6723cac9f12a982381a

@moosebuild
Copy link
Contributor

moosebuild commented Nov 11, 2025

Job Documentation, step Docs: sync website on 69da395 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Nov 12, 2025

Job Coverage, step Generate coverage on 69da395 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Thermal hydraulics

b79a48 #31892 69da39
Total Total +/- New
Rate 88.65% 88.69% +0.05% 100.00%
Hits 14916 14992 +76 77
Misses 1910 1911 +1 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@joshuahansel joshuahansel marked this pull request as ready for review November 12, 2025 14:38
Comment on lines 36 to 48
// Area
const ADVariableValue & _A1;
const ADVariableValue & _A2;

// reconstructed variable values in this cell
const ADMaterialProperty<Real> & _rhoA1;
const ADMaterialProperty<Real> & _rhouA1;
const ADMaterialProperty<Real> & _rhoEA1;

// reconstructed variable values in neighbor cell
const ADMaterialProperty<Real> & _rhoA2;
const ADMaterialProperty<Real> & _rhouA2;
const ADMaterialProperty<Real> & _rhoEA2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Area
const ADVariableValue & _A1;
const ADVariableValue & _A2;
// reconstructed variable values in this cell
const ADMaterialProperty<Real> & _rhoA1;
const ADMaterialProperty<Real> & _rhouA1;
const ADMaterialProperty<Real> & _rhoEA1;
// reconstructed variable values in neighbor cell
const ADMaterialProperty<Real> & _rhoA2;
const ADMaterialProperty<Real> & _rhouA2;
const ADMaterialProperty<Real> & _rhoEA2;
/// Area
const ADVariableValue & _A1;
const ADVariableValue & _A2;
/// reconstructed variable values in this cell
const ADMaterialProperty<Real> & _rhoA1;
const ADMaterialProperty<Real> & _rhouA1;
const ADMaterialProperty<Real> & _rhoEA1;
/// reconstructed variable values in neighbor cell
const ADMaterialProperty<Real> & _rhoA2;
const ADMaterialProperty<Real> & _rhouA2;
const ADMaterialProperty<Real> & _rhoEA2;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would apply those comments only to the first in each group. I'll just do the dox for each member individually

@moosebuild
Copy link
Contributor

Job Test, step Results summary on 69da395 wanted to post the following:

Framework test summary

Compared against b79a48d in job civet.inl.gov/job/3380566.

No change

Modules test summary

Compared against b79a48d in job civet.inl.gov/job/3380566.

Added tests

Test Time (s)
thermal_hydraulics/test:components/flow_channel_1phase.output_vpps 1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add options to flow channel to output VPPs

3 participants