-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added VPP output options to flow channel #31892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
d06848b to
ecb2cde
Compare
|
Job Precheck, step Clang format on ecb2cde wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
ecb2cde to
642a62d
Compare
|
Job Documentation, step Docs: sync website on 69da395 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 69da395 wanted to post the following: Framework coverageCoverage did not change Modules coverageThermal hydraulics
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
| // Area | ||
| const ADVariableValue & _A1; | ||
| const ADVariableValue & _A2; | ||
|
|
||
| // reconstructed variable values in this cell | ||
| const ADMaterialProperty<Real> & _rhoA1; | ||
| const ADMaterialProperty<Real> & _rhouA1; | ||
| const ADMaterialProperty<Real> & _rhoEA1; | ||
|
|
||
| // reconstructed variable values in neighbor cell | ||
| const ADMaterialProperty<Real> & _rhoA2; | ||
| const ADMaterialProperty<Real> & _rhouA2; | ||
| const ADMaterialProperty<Real> & _rhoEA2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Area | |
| const ADVariableValue & _A1; | |
| const ADVariableValue & _A2; | |
| // reconstructed variable values in this cell | |
| const ADMaterialProperty<Real> & _rhoA1; | |
| const ADMaterialProperty<Real> & _rhouA1; | |
| const ADMaterialProperty<Real> & _rhoEA1; | |
| // reconstructed variable values in neighbor cell | |
| const ADMaterialProperty<Real> & _rhoA2; | |
| const ADMaterialProperty<Real> & _rhouA2; | |
| const ADMaterialProperty<Real> & _rhoEA2; | |
| /// Area | |
| const ADVariableValue & _A1; | |
| const ADVariableValue & _A2; | |
| /// reconstructed variable values in this cell | |
| const ADMaterialProperty<Real> & _rhoA1; | |
| const ADMaterialProperty<Real> & _rhouA1; | |
| const ADMaterialProperty<Real> & _rhoEA1; | |
| /// reconstructed variable values in neighbor cell | |
| const ADMaterialProperty<Real> & _rhoA2; | |
| const ADMaterialProperty<Real> & _rhouA2; | |
| const ADMaterialProperty<Real> & _rhoEA2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would apply those comments only to the first in each group. I'll just do the dox for each member individually
modules/thermal_hydraulics/src/vectorpostprocessors/NumericalFlux3EqnInternalValues.C
Outdated
Show resolved
Hide resolved
642a62d to
69da395
Compare
|
Job Test, step Results summary on 69da395 wanted to post the following: Framework test summaryCompared against b79a48d in job civet.inl.gov/job/3380566. No change Modules test summaryCompared against b79a48d in job civet.inl.gov/job/3380566. Added tests
|
Added options to
FlowChannel1Phasefor outputting quantities via VPPs:vpp_vars: Creates anElementValueSamplerwith a vector for each of the listed variablescreate_flux_vpp: Creates aNumericalFlux3EqnInternalValues, which creates a vector for each numerical flux component (mass, momentum, energy) at the internal sidesCloses #31891