-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added CoupledInjectionProductionPhysics #31900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
Job Documentation, step Docs: sync website on d907db8 wanted to post the following: View the site here This comment will be updated on new commits. |
e13976b to
d344f3f
Compare
d344f3f to
d907db8
Compare
|
Job Test, step Results summary on d907db8 wanted to post the following: Framework test summaryCompared against 7edd10c in job civet.inl.gov/job/3374418. No change Modules test summaryCompared against 7edd10c in job civet.inl.gov/job/3374418. Added tests
|
|
Job Coverage, step Generate coverage on d907db8 wanted to post the following: Framework coverageCoverage did not change Modules coveragePorous flow
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
grmnptr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool capability! Let's also wait for the code owner review!
Being a frequent code owner I can tell you that this is usually ignored 😄 @cpgr any objections with this? It is used in some coupling work I am doing between THM and porous flow. Once all of the pieces are in place, I should have a decent example in Falcon. |
I always miss these code owner ones too! Would this allow us to easily do porous media flow for a reservoir coupled to non-porous media flow in a well? Sounds like a good thing to me |
Yes, this is the coupling I've been working on. The wells are 1D pipes from THM and are coupled through junctions via MultiApps. |
Great! This will be super useful to me too. Thanks for this |
Closes #31899