Skip to content

Conversation

@joshuahansel
Copy link
Contributor

Closes #31899

@joshuahansel joshuahansel requested a review from grmnptr November 12, 2025 14:37
@joshuahansel joshuahansel self-assigned this Nov 12, 2025
@moosebuild
Copy link
Contributor

moosebuild commented Nov 12, 2025

Job Documentation, step Docs: sync website on d907db8 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Test, step Results summary on d907db8 wanted to post the following:

Framework test summary

Compared against 7edd10c in job civet.inl.gov/job/3374418.

No change

Modules test summary

Compared against 7edd10c in job civet.inl.gov/job/3374418.

Added tests

Test Time (s)
porous_flow/test:physics/coupled_injection_production_physics.test 1.12

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on d907db8 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Porous flow

7edd10 #31900 d907db
Total Total +/- New
Rate 95.49% 95.54% +0.04% 100.00%
Hits 11422 11497 +75 73
Misses 539 537 -2 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@joshuahansel joshuahansel marked this pull request as ready for review November 13, 2025 14:29
@joshuahansel joshuahansel requested a review from cpgr as a code owner November 13, 2025 14:29
Copy link
Contributor

@grmnptr grmnptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool capability! Let's also wait for the code owner review!

@joshuahansel
Copy link
Contributor Author

Pretty cool capability! Let's also wait for the code owner review!

Being a frequent code owner I can tell you that this is usually ignored 😄 @cpgr any objections with this? It is used in some coupling work I am doing between THM and porous flow. Once all of the pieces are in place, I should have a decent example in Falcon.

@cpgr
Copy link
Contributor

cpgr commented Nov 13, 2025

Pretty cool capability! Let's also wait for the code owner review!

Being a frequent code owner I can tell you that this is usually ignored 😄 @cpgr any objections with this? It is used in some coupling work I am doing between THM and porous flow. Once all of the pieces are in place, I should have a decent example in Falcon.

I always miss these code owner ones too!

Would this allow us to easily do porous media flow for a reservoir coupled to non-porous media flow in a well? Sounds like a good thing to me

@joshuahansel
Copy link
Contributor Author

Would this allow us to easily do porous media flow for a reservoir coupled to non-porous media flow in a well?

Yes, this is the coupling I've been working on. The wells are 1D pipes from THM and are coupled through junctions via MultiApps.

@cpgr
Copy link
Contributor

cpgr commented Nov 13, 2025

Would this allow us to easily do porous media flow for a reservoir coupled to non-porous media flow in a well?

Yes, this is the coupling I've been working on. The wells are 1D pipes from THM and are coupled through junctions via MultiApps.

Great! This will be super useful to me too. Thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add porous flow Physics for coupled dirac sources

4 participants