MFiX interface develop #2490
Open
MFiX interface develop #2490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 30, 2025 10:53
…us for temperary patch, CodeInterfaceBaseClass.py is changed.
…ace functionality works without generating errors.
…VEN input (i.e., <NumThreads>) is identical with the multiplication of nodesi, nodesj, and nodesk in the MFiX input file is completed.
added 14 commits
May 5, 2025 14:34
… a relative path.
… it interfaceCheck only.
…t from the test file.
|
Job Test Ubuntu 20-2 Optional on 173e987 : invalidated by @joshua-cogliati-inl restarted civet |
joshua-cogliati-inl
previously requested changes
May 9, 2025
Contributor
joshua-cogliati-inl
left a comment
joshua-cogliati-inl
left a comment
There was a problem hiding this comment.
Just a quick change request (I haven't done a full review). Thanks.
|
Job Test Ubuntu 18-2 Python 3 on 5c43f5a : invalidated by @joshua-cogliati-inl cleaned computer filesystem so more room available |
alfoa
reviewed
May 16, 2025
Comment on lines
47
to
67
| self.deltaH = 0.001 # set value for the change in height | ||
| self.deltaVol = 0.1 # volume fraction assumed to be the upper limit for the bed | ||
| self.slopeStop = self.deltaVol / self.deltaH # calculate the limit on the change in slope to determine bed height | ||
| self.dPart = 2.5e-4 # particle volume (m) | ||
| # particle diameter: d_p0(1) = 6.9e-4 | ||
| # self.rTol = self.dPart / 1000 # tolerance for particle diameter | ||
| self.rTol = 2.e-3 # TODO read from MFIX input file d_p0(1) * 2 | ||
| self.rHem = 0.0045 # radius of hemispherical section at the bottom of the cone | ||
| self.hOff = self.rHem / np.tan(np.pi / 6) # height of the cone at the bottom of the cone ( height of the hemispherical section) | ||
| self.nYMesh = 115 | ||
| self.basePartFile = 'BACKGROUND_IC_*.vtp' # Polygonal data, 2D grid, like the unstructured grid, but there are no polyhedra, but only flat polygons. | ||
| self.cellPartFile = 'X_SLICE_*.vtu' # Unstructured grid: 2D or 3D grid; for every grid point all three coordinates and for each grid cell all constituent points and the cell shape are given | ||
| self.moveAgeWindow = 5 | ||
| self.errTol = 0.0001 | ||
| # self.heightBin = 0.01 | ||
| self.numParticle = 3 | ||
| self.heightBin = self.numParticle * self.dPart | ||
| self.coneRadius = 0.0254 #meters | ||
| self.coneHeight = 0.045 #meters | ||
| self.slantHeight = 0.0507204 # meters | ||
| self.cylinderAboveConeHeight = 0.17780 + self.coneHeight |
Collaborator
There was a problem hiding this comment.
why all these geometrical hard coded variables/values?
…ode under Samplers nodes.
… script commandline is updated so that file_path in shell script is not needed anymore.
…d in the test file.
…deck - dealing with perturbation varaibles needs to be revisited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#2489
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.