Skip to content

Conversation

@wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Oct 26, 2025


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

see #1806

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Test mac on 9b3fc4f : invalidated by @wangcj05

@moosebuild
Copy link

Job Test mac on f38d3a0 : invalidated by @wangcj05

@moosebuild
Copy link

Job Test qsubs sawtooth on cad921d : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Test slurm bitterroot on cad921d : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Mingw Test on cad921d : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Test slurm bitterroot on cad921d : invalidated by @joshua-cogliati-inl

set python environment timed out

@joshua-cogliati-inl
Copy link
Contributor

I took a quick look and it looks reasonable. Thanks.

Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed and I approve.

@joshua-cogliati-inl
Copy link
Contributor

@PaulTalbot-INL @wangcj05 @mandd This has failing tests, but so does trivial whitespace change: https://civet.inl.gov/pr/18540/

I am fine with it being merged with failing tests since it has fewer failing than devel currently does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants