Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct outbound validation. #391

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Conversation

TreyE
Copy link
Contributor

@TreyE TreyE commented May 22, 2024

PR Checklist

Please check if your PR fulfills the following requirements

  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/story/show/187646855

A brief description of the changes

Current behavior: Business rule validations using the CMS provided schematron are not executed on outbound payloads.

New behavior: Outbound payloads will now be subject to the validations.

@TreyE TreyE force-pushed the fix_outbound_validation_issues branch from acc4d56 to b10873e Compare May 22, 2024 20:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pattern of having gems internally in a project has proved to be problematic in enroll, I know this is an internal gem, but shouldn't be better to have it own its repo? it will make it easier to track and to re-use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants