-
Notifications
You must be signed in to change notification settings - Fork 2
Feat/offchain aggregation #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution looks good, I think that we should still have a Pulse object or something similar that we can control with a trait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the main comment as it closes #230, it does not fully close #229 as there are some comments and docs related to the filtering so I didn't add it to the comment too.
The PR looks good, a lot of simplifications that I love. The thing that worries me the most is the most is the change from 2s to 4s block time
@driemworks I have also added this small PR #241 for updating the |
…-sdk into feat/offchain-aggregation
This PR solves two issues encountered while running as a parachain collator.
It partially addresses #211
It close #224
It closes #231
It closes #230