Skip to content

IDN consumer chain - contracts configuration #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 19, 2025
Merged

IDN consumer chain - contracts configuration #248

merged 7 commits into from
May 19, 2025

Conversation

carloskiron
Copy link
Contributor

@carloskiron carloskiron commented May 18, 2025 •
edited
Loading

Overview

This pull request has the following improvements:

  1. Updates the ContractPulse implementation to align with the latest Pulse trait
  2. Configures essential pallets in the consumer chain runtime for smart contract functionality

Changes in Detail

ContractPulse Implementation

  • Updated ContractPulse to properly implement the latest Pulse trait
  • Fixed the message() method implementation
  • Updated contract tests to work with the revised data structure

Runtime Pallet Configuration

  • Added and configured the Contracts pallet
  • Added and configured the Revive pallet
  • Added pallet_insecure_randomness_collective_flip for contract randomness
  • Implemented required API traits (ContractsApi, ReviveApi)

closes #183

@carloskiron
Refine pallet configurations and contract implementation
8e2be9d 
- Reordered and organized Config trait implementations for better readability
- Fixed ContractPulse implementation to match the latest Pulse trait
- Updated dependencies for Contracts and Revive pallets
- Enhanced APIs implementation for proper integration
- Formatted code according to Rust standards
@carloskiron carloskiron changed the title Fix ContractPulse and Runtime Pallet Configuration IDN Consumer chain - contracts configuration May 19, 2025
@carloskiron carloskiron changed the title IDN Consumer chain - contracts configuration IDN consumer chain - contracts configuration May 19, 2025
juangirini
juangirini reviewed May 19, 2025
View reviewed changes
juangirini
juangirini reviewed May 19, 2025
View reviewed changes
@carloskiron
Clean up configuration and improve documentation
cee24c1 
- Fix import statements in config files to remove redundant imports
- Streamline runtime configurations for contracts and revive
- Remove unused dependencies from Cargo.toml
- Move e2e testing instructions from code comments to README.md
- Clean up code organization
juangirini
juangirini approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

driemworks
driemworks approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@driemworks driemworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carloskiron carloskiron merged commit 2d9bd6b into main May 19, 2025
5 checks passed
@carloskiron carloskiron deleted the cm/contracts-consumer-runtime-config branch May 19, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juangirini juangirini juangirini approved these changes

@driemworks driemworks driemworks approved these changes

@colemanirby colemanirby Awaiting requested review from colemanirby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add contracts pallet + idn contract to the consumer chain
3 participants
@carloskiron @juangirini @driemworks