Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version number parsing in the event of two digits minor #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

upaternostro
Copy link

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

I simply added a split at version number parsing instead of cutting the string at character positions.

Please note that Oracle also changed the URL path, adding a "0", so I had to add this hack in my site.yml:

  instant_client_version: 19.19.0.0.0.0
  instant_client_basic_release_name: instantclient-basic-{{ instant_client_release_system }}-19.19.0.0.0dbru
  instant_client_devel_release_name: instantclient-sdk-{{ instant_client_release_system }}-19.19.0.0.0dbru
  instant_client_sqlplus_release_name: instantclient-sqlplus-{{ instant_client_release_system }}-19.19.0.0.0dbru

Benefits

Oracle released new Instant Client versions with a two-digits minor number (i.e. 19.19.0.0.0 or 21.10.0.0.0), this patch makes those numbers parsable.

Possible Drawbacks

None?

Applicable Issues

N/A

@nermin-imamovic
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants