-
Notifications
You must be signed in to change notification settings - Fork 201
Added rest of the Persian models the guy made #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Thanks for showing me the correct way to implement these, hope this one also looks good :) |
Whats the zoo test? |
Is it failing because some of the config files have weird names for some of the vits models?? |
The zoo tests download and run every model in
Yes, Coqui always expects that file to be named coqui-ai-TTS/TTS/utils/manage.py Lines 371 to 373 in fb71e2a
We could do something similar if there is only one coqui-ai-TTS/TTS/utils/manage.py Line 451 in fb71e2a
Let me know if you'd like to do that, otherwise I can take care of it in a few days. |
I'll give it a go tomorrow I suppose Thx for the info btw I'm excited to get to learn here as I really want to help out and add to this repo, |
Here I attempted at adding it here? Was trying to make it so that it would would handle renaming config files if there's only one JSON file in the directory? Did I do that correctly or.... |
Also is it best to do that modification here in this existing PR? |
@eginhard as the workflow logs are expired could you tell me what's the issue to solve here? or mayb re-run the workflow so I can work on it? |
I pulled the information from this app.py from his hugginface space that demo's them
https://huggingface.co/spaces/Kamtera/Persian-tts-CoquiTTS
relevant info being...