Feature/prompt for configfile to load and save #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 📈 Add a chart showing activity when in csv output mode * 🔇 Update when log mode is debug, chart is not shown * Debian package (#71) * ✏️ Update readme with better logging explanation * 📦 Add debian build dpkg files
Collaborator
Author
|
@mielverkerken This is now ready for review and additional testing. |
* 🐛 Fix missing padding * ➕ Add buffer size for the ipv6, so the buffers are as large as the ipv4
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self.dest | ||
| } | ||
| fn window_size(&self) -> u16 { | ||
| self.window as u16 |
Check warning
Code scanning / clippy
casting to the same type is unnecessary (u16 -> u16) Warning
* create rustiflow feature set * refactor of features into sub structs * include flow expiration cause and support updating stats on expiration * export icmp code from ebpf * update rustiflow feature set * use microseconds since epoch instead of Datetime to limit memory * set default threads to 5 * update dropped packets * update * extra packet features * update rustiflow features * review comments
| false | ||
| } | ||
|
|
||
| fn close_flow(&mut self, _timestamp_us: i64, _cause: FlowExpireCause) -> () { |
Check warning
Code scanning / clippy
unneeded unit return type Warning
| use chrono::{DateTime, Utc}; | ||
| use std::net::IpAddr; | ||
|
|
||
| use chrono::format; |
Check warning
Code scanning / clippy
unused import: chrono::format Warning
Comment on lines
+37
to
+41
| } else { | ||
| if !self.bwd_seen_seqs.insert(seq) { | ||
| self.bwd_retransmission_count += 1; | ||
| } | ||
| } |
Check warning
Code scanning / clippy
this else { if .. } block can be collapsed Warning
mielverkerken
approved these changes
Mar 3, 2025
matissecallewaert
deleted the
feature/prompt-for-configfile-to-load-and-save
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the prompting for a configuration file and saving a configuration file to the tui itself.
And additional features
This is tested on my machine 🧪