[Imported] fix images in dark theme #400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Additional question, build an exchange fixes donnemartin#281 * Update README.md Co-authored-by: Donne Martin <[email protected]>
…been discontinued
…been discontinued (#500) @lerignoux thank you!
fix issues donnemartin#525 , #495 , #515 that some images are not visible in GitHub dark mode.
|
Imported comment from @m-s-abeer Is it going to be merged? |
|
Imported comment from @izzygomez @donnemartin this is a trivial change that has been ready to be merged for years that'll improve readability for a significant segment of repository readers. could this be prioritized? |
|
Imported review by @bschauerte State: APPROVED Fixes the issues with transparent background in dark mode |
anandfresh
pushed a commit
that referenced
this pull request
Apr 22, 2025
* ja-Translation: Follows #433 * ja-Translation: Follows #350 * ja-Translation: Follows #348 * ja-Translation: Follows #439 * ja-Translation: Follows #351 * ja-Translation: Follows #411 * ja-Translation: Follows #328 * ja-Translation: Follows #441, #108 * ja-Translation: Follows #400 * ja-Translation: Follows #321 * Update README-ja.md --------- Co-authored-by: Ryo Shibayama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported from donnemartin/system-design-primer#534
Original author: @LowLevelLover
fix issues donnemartin#525, #495, #515 that some images are not visible in GitHub dark mode. Add background to transparent pictures.