Skip to content

[Imported] small changes #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 134 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
134 commits
Select commit Hold shift + click to select a range
c3f080f
Update Japanese translation link (#118)
donnemartin Dec 3, 2017
a4973a0
ja: Fix typo (#119)
koudaiii Dec 8, 2017
748944c
Make some minor wording/formatting changes (#120)
donnemartin Jan 6, 2018
dd124c4
add Twitter Handles 3,000 Images Per Second
fluency03 Jan 6, 2018
11b9d72
Add Netflix in Company Architectures (#122)
fluency03 Jan 21, 2018
8702199
Add Vietnamese translation link (#128)
donnemartin Jan 24, 2018
156a67e
Add Scaling Uber in Company Architecture (#123)
fluency03 Feb 2, 2018
ebcec73
Update master-slave section anchor (#129)
Feb 8, 2018
0263906
Add Facebook Live Streams (#125)
fluency03 Feb 16, 2018
12946d3
Update contributing guidelines - PR squash (#135)
donnemartin Feb 23, 2018
61bc6f7
Update re:Invent url (#137)
hakaari Feb 27, 2018
e86ed77
Merge branch 'master' into add-twitter
fluency03 Feb 27, 2018
9712a12
Add Traditional Chinese translation (#133)
kevingo Feb 28, 2018
82868d3
zh-TW: Add proper line break to links (#139)
kevingo Mar 4, 2018
7272a9b
Add Greek translation link (#140)
donnemartin Mar 6, 2018
de3c13c
Convert all .py files to be valid Python (#98)
Mar 7, 2018
94c158e
zh-Hans: Fix typos (#141)
robertding Mar 8, 2018
7c38532
Add Spanish translation link (#142)
donnemartin Mar 8, 2018
3079562
Add missing colons to class methods (#143)
Mar 18, 2018
d90b562
Add missing self variables to Deck of Cards solution (#145)
Mar 18, 2018
7e316ce
Add deque import to Social Graph solution (#147)
Mar 24, 2018
f552598
Change LARGE to VehicleSize.LARGE in parking lot solution (#146)
Apr 9, 2018
f038dbb
zh-TW: Fix comment format (#155)
htkuan Apr 11, 2018
d7d0e9d
Fix coding errors (#149)
Apr 26, 2018
f05373a
Fix dict KeyError (#152)
hulikau Apr 26, 2018
7a4dbb1
Fix dict KeyError (#153)
hulikau Apr 26, 2018
4a0d7fb
Adding missing self variable (#158)
May 7, 2018
02a20c6
Add missing enum imports (#157)
May 7, 2018
2368ee0
Change variable seller to category in Mint solution (#159)
May 23, 2018
38cb1be
zh-Hans: Fix typo (#161)
b7wch Jun 16, 2018
6ed6521
Replace broken SQL tuning links (#163)
Jun 29, 2018
ded61ab
zh-Hans: Fix PostgreSQL typo (#166)
breakliu Jul 13, 2018
7b20f5c
Fix #148: Add State(Enum) to social_graph_snippets.py (#167)
Jul 15, 2018
8a9cca7
ja: Swap VARCHAR and CHAR translation error (#169)
Jul 15, 2018
4cc5ff4
Add Arabic translation link (#177)
donnemartin Jul 18, 2018
65685dc
Add newlines - PEP8 style (#173)
Jul 19, 2018
6b18bd8
zh-TW: Improve translations (#176)
d12e493 Jul 20, 2018
46eead5
Fix typo in LRU cache solution (#182)
veloxy Jul 23, 2018
be5b372
Fix broken links (#180)
zboigor Jul 25, 2018
21a088d
Add German translation link (#188)
donnemartin Jul 30, 2018
c6ce4e0
Add Thai translation link (#190)
donnemartin Aug 1, 2018
8da1030
Fix broken URL (#194)
RGirish Aug 5, 2018
99aaf14
Fix error in Twitter timeline solution (#196)
Aug 7, 2018
64e1379
Fix wording in call center solution (#197)
HasanAliKaraca Aug 9, 2018
2107618
Resolve #195: Fix broken GitHub URLs (#199)
narenchoudhary Aug 13, 2018
c20f0e4
zh-Hans: Fix typo: 'Twitter' (#200)
meteor199 Aug 14, 2018
0d9a863
Update Twitter/Facebook exercise description (#202)
fabriziocucci Aug 20, 2018
bddaa27
Fix typo in CAP theorem section (#205)
Aug 24, 2018
a57d6a1
Fix broken links (#204)
karoliina Aug 29, 2018
13c6a5b
Fix #126: Update link to Anki decks (#206)
dvanbrug Sep 2, 2018
29ad5b2
Fix typo in Design Pastebin.com exercise (#210)
fabriziocucci Sep 8, 2018
97d8aee
zh-Hans: Fix translation (#208)
uknownothingsnow Sep 14, 2018
78262c0
zh-Hans: Update translation (#212)
xulunfan Sep 15, 2018
adf0b44
zh-Hans: Update translation (#209)
dajiao007 Sep 16, 2018
25d7744
Update Cassandra architecture links (#213)
brunoffsp Sep 19, 2018
2da470f
Update README intro (#216)
donnemartin Sep 24, 2018
ac44939
Resolve #214: Add reference links to message queues section (#218)
IAmPramod Oct 1, 2018
c8e819c
Update Scalability for Dummies link (#224)
Xom Oct 11, 2018
4d50e1e
ja: Fix typo (#226)
masaodev Oct 26, 2018
38f1986
zh-TW: Update index anchors (#227)
reiscigit Oct 31, 2018
c210cfb
Add Link: A 360 Degree View Of The Entire Netflix Stack (#229)
fluency03 Nov 14, 2018
470cb75
Fix #228: Address mutex latency discrepancy (#233)
saurav-2104 Dec 19, 2018
3468768
Add Bengali translation link (#242)
donnemartin Dec 28, 2018
7095562
Add missing word in cache write through discussion (#245)
whoan Jan 5, 2019
05cca98
zh-Hans: Fix typo (#246)
ZJUGuoShuai Jan 20, 2019
b2d08cd
Fix grammar in document store section (#247)
Feb 3, 2019
3d2f11f
Fix typo in Twitter timeline and search solution (#251)
Feb 11, 2019
fc121f9
Update document-store to document store (#255)
t0t07 Feb 28, 2019
25c448f
Enable Python syntax highlighting in Pastebin sample code (#257)
manaskarekar Mar 4, 2019
70f714d
Fix broken SQL link in Scaling AWS exercise (#258)
CodeMySky Mar 18, 2019
5801dee
Add article link: How Twitter Handles 3,000 Images/sec (#124)
donnemartin Apr 10, 2019
df045a4
Update HDFS design link to the latest version (#275)
leontyr May 7, 2019
255dcf8
Enable syntax highlighting in all python code snippets (#268)
manaskarekar May 7, 2019
fc8568a
Translate language list (#252)
spuyet May 11, 2019
3c2b831
Add Ebook generation script (#207)
Skn0tt May 12, 2019
d2384bd
Add availability in numbers section (#237)
mebjas May 12, 2019
9058471
Update language lists in translations (#280)
donnemartin May 14, 2019
f5c39e0
Add Hebrew translation link (#286)
donnemartin May 31, 2019
6a5d2fe
zh-Hans: Translate Pastebin solution (#273)
kevinxuv Jun 16, 2019
014a4a0
ja: Fix typo of Big-O notation in KVS section (#292)
Wintus Jul 6, 2019
9ffe72e
JA: Fix mistranslation in Horizontal scaling section
satob Jul 8, 2019
71f1693
JA: Fix mistranslation in Reverse proxy (web server) section
satob Jul 10, 2019
4956d22
ja: Fix mistranslation in "Horizontal scaling"
satob Jul 26, 2019
06eeeb7
JA: Fix mistranslation in Weak consistency section (#299)
satob Aug 3, 2019
218a23d
JA: Fix mistranslation in Push CDNs section (#300)
satob Aug 3, 2019
87912ed
ja: Fix translation in horizontal scaling section (#301)
donnemartin Aug 3, 2019
316c00c
Merge pull request #302 from satob/ReverseProxy
donnemartin Aug 3, 2019
46634d1
JA: Fix mistranslation in Federation section (#303)
satob Aug 5, 2019
779b466
ja: Fix translation in "Anki flashcards" (#306)
satob Aug 13, 2019
b44a018
ja: Fix translation in “Disadvantage(s): load balancer” (#307)
satob Aug 13, 2019
8bfc344
ja: Fix translation in Service Discovery section (#308)
satob Aug 13, 2019
1972808
Add API security checklist (#328)
duynguyenhoang Nov 3, 2019
ce29593
zh-Hans: Change translation in SQL tuning (#318)
brandonJY Dec 9, 2019
7f56907
ja: Fix mistranslation in SQL tuning section (#305)
satob Dec 9, 2019
24707af
Change raise NotImplemented to raise NotImplementedError (#345)
cclauss Dec 27, 2019
ba69584
Fix broken round robin links (#351)
ygdanchoi Jan 15, 2020
105fa53
Fix broken CAP theorem link (#355)
Jan 21, 2020
e69177f
zh-cn: Sync with upstream to keep it up-to-date (#374)
linhe0x0 Mar 10, 2020
1886ed9
Revert "zh-cn: Sync with upstream to keep it up-to-date (#374)" (#391)
donnemartin Mar 10, 2020
752f6aa
zh-Hans: Translate solutions (#392)
linhe0x0 Mar 30, 2020
53ebbd1
Update "Scaling up to your first 10 million users" link (#411)
userstartupideas May 26, 2020
52d051a
Add missing comma in Mint solution (#399)
alexanderteno Jul 1, 2020
a9ab5ad
Fix single point of failure typo (#398)
panguncle Jul 1, 2020
b2704fe
Fix layer 7 load balancers typo (#317)
shiyujiucsb Jul 1, 2020
87ad249
Update contributing guidelines for translations (#434)
donnemartin Jul 2, 2020
92e6b11
Add pull request template (#435)
donnemartin Jul 2, 2020
a42b076
Add status of translations (#436)
donnemartin Jul 3, 2020
7011291
Highlight translation request (#437)
donnemartin Jul 3, 2020
a61d62f
Resolve #164 - Fix phrasing with availability and partition tolerance…
neesara Jul 4, 2020
7b495be
Check dependencies in Ebook gen script (#406)
sainadh-d Jul 4, 2020
c55c941
Fix typo: Change replication to federation (#418)
kevinliu23 Jul 4, 2020
8bb74cd
Update Twitter back-of-the-envelope calculations (#414)
kof-f Jul 4, 2020
071d84d
Fix typos in Twitter and web crawler exercises (#438)
Agade09 Jul 5, 2020
a23ab1e
Fix #313: Clarify availability patterns (#439)
nacharya-msft Jul 5, 2020
7ee4c1d
Add system design template link (#433)
rahilsh Jul 5, 2020
92014a4
kr: Fix Korean translation link in language index (#340)
youngchul Jul 5, 2020
6cce656
Fix Mint exercise bugs and typos (#409)
vemikhaylov Jul 7, 2020
eae7ed2
Remove redundant SQL index in Pastebin exercise (#405)
John-Richardson Jul 7, 2020
fba0504
Additional question, build an exchange
morenoh149 Jul 7, 2020
d47546b
Add CAP theorem video link (#400)
hiscodesmells Jul 8, 2020
572ad46
Fix loop bug in deck of cards exercise (#396)
joilson-cisne Jul 8, 2020
8c19ffc
Update dead links (#321)
ganesshkumar Jul 9, 2020
cd7907e
Add links for latency based and geolocation based routing (#319)
varshavjm Jul 10, 2020
50e9d7a
Clarify CDN advantages (#310)
noebrito Jul 10, 2020
e9f62f1
Change disk to HDD for clarity (#295)
ad-m Jul 11, 2020
22054f4
Update README.md
donnemartin Jul 12, 2020
c0330a0
Resolve #281: Add design stock exchange links (#441)
donnemartin Jul 12, 2020
cca3e03
Remove extraneous __init__.py (#393)
donnemartin Jul 12, 2020
f655458
Remove Imgur dependency by storing images locally (#168)
danieljl Jul 18, 2020
2fa0808
Fix #335: Update OSI image to Open Systems Interconnection (#447)
iravitejakumar Aug 2, 2020
a910106
Fix translations link in PR template (#451)
serima Aug 2, 2020
a078026
Update broken HBase architecture link (#481)
peteryao7 Oct 30, 2020
cdfdeb0
Fix Celery URL (#486)
sharpcodex Dec 29, 2020
79a55a1
small changes
sky3760000 Jan 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
## Review the Contributing Guidelines

Before submitting a pull request, verify it meets all requirements in the [Contributing Guidelines](https://github.com/donnemartin/system-design-primer/blob/master/CONTRIBUTING.md).

### Translations

See the [Contributing Guidelines](https://github.com/donnemartin/system-design-primer/blob/master/CONTRIBUTING.md). Verify you've:

* Tagged the [language maintainer](https://github.com/donnemartin/system-design-primer/blob/master/TRANSLATIONS.md)
* Prefixed the title with a language code
* Example: "ja: Fix ..."
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Byte-compiled / optimized / DLL files
*.epub
__pycache__/
*.py[cod]

Expand Down
33 changes: 20 additions & 13 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,26 +45,33 @@ If you are not familiar with pull requests, review the [pull request docs](https
We'd like for the guide to be available in many languages. Here is the process for maintaining translations:

* This original version and content of the guide is maintained in English.
* Translations follow the content of the original. Unfortunately, contributors must speak at least some English, so that translations do not diverge.
* Each translation has a maintainer to update the translation as the original evolves and to review others' changes. This doesn't require a lot of time, but review by the maintainer is important to maintain quality.
* Translations follow the content of the original. Contributors must speak at least some English, so that translations do not diverge.
* Each translation has a maintainer to update the translation as the original evolves and to review others' changes. This doesn't require a lot of time, but a review by the maintainer is important to maintain quality.

See [Translations](TRANSLATIONS.md).

### Changes to translations

* Changes to content should be made to the English version first, and then translated to each other language.
* Changes that improve translations should be made directly on the file for that language. PRs should only modify one language at a time.
* Submit a PR with changes to the file in that language. Each language has a maintainer, who reviews changes in that language. Then the primary maintainer @donnemartin merges it in.
* Prefix PRs and issues with language codes if they are for that translation only, e.g. "es: Improve grammar", so maintainers can find them easily.
* Changes that improve translations should be made directly on the file for that language. Pull requests should only modify one language at a time.
* Submit a pull request with changes to the file in that language. Each language has a maintainer, who reviews changes in that language. Then the primary maintainer [@donnemartin](https://github.com/donnemartin) merges it in.
* Prefix pull requests and issues with language codes if they are for that translation only, e.g. "es: Improve grammar", so maintainers can find them easily.
* Tag the translation maintainer for a code review, see the list of [translation maintainers](TRANSLATIONS.md).
* You will need to get a review from a native speaker (preferably the language maintainer) before your pull request is merged.

### Adding translations to new languages

Translations to new languages are always welcome, especially if you can maintain the translation!

* Check existing issues to see if a translation is in progress or stalled. If so, offer to help.
* If it is not in progress, file an issue for your language so people know you are working on it and we can arrange. Confirm you are native level in the language and are willing to maintain the translation, so it's not orphaned.
* To get it started, fork the repo, then submit a PR with the single file README-xx.md added, where xx is the language code. Use standard [IETF language tags](https://www.w3.org/International/articles/language-tags/), i.e. the same as is used by Wikipedia, *not* the code for a single country. These are usually just the two-letter lowercase code, for example, `fr` for French and `uk` for Ukrainian (not `ua`, which is for the country). For languages that have variations, use the shortest tag, such as `zh-Hant`.
* Invite friends to review if possible. If desired, feel free to invite friends to help your original translation by letting them fork your repo, then merging their PRs.
* Add links to your translation at the top of every README*.md file. (For consistency, the link should be added in alphabetical order by ISO code, and the anchor text should be in the native language.)
* When done, indicate on the PR that it's ready to be merged into the main repo.
Translations to new languages are always welcome! Keep in mind a transation must be maintained.

* Do you have time to be a maintainer for a new language? Please see the list of [translations](TRANSLATIONS.md) and tell us so we know we can count on you in the future.
* Check the [translations](TRANSLATIONS.md), issues, and pull requests to see if a translation is in progress or stalled. If it's in progress, offer to help. If it's stalled, consider becoming the maintainer if you can commit to it.
* If a translation has not yet been started, file an issue for your language so people know you are working on it and we'll coordinate. Confirm you are native level in the language and are willing to maintain the translation, so it's not orphaned.
* To get started, fork the repo, then submit a pull request to the main repo with the single file README-xx.md added, where xx is the language code. Use standard [IETF language tags](https://www.w3.org/International/articles/language-tags/), i.e. the same as is used by Wikipedia, *not* the code for a single country. These are usually just the two-letter lowercase code, for example, `fr` for French and `uk` for Ukrainian (not `ua`, which is for the country). For languages that have variations, use the shortest tag, such as `zh-Hant`.
* Feel free to invite friends to help your original translation by having them fork your repo, then merging their pull requests to your forked repo. Translations are difficult and usually have errors that others need to find.
* Add links to your translation at the top of every README-XX.md file. For consistency, the link should be added in alphabetical order by ISO code, and the anchor text should be in the native language.
* When you've fully translated the English README.md, comment on the pull request in the main repo that it's ready to be merged.
* You'll need to have a complete and reviewed translation of the English README.md before your translation will be merged into the `master` branch.
* Once accepted, your pull request will be squashed into a single commit into the `master` branch.

### Translation template credits

Expand Down
Loading