Skip to content

[Imported] Fix #493 : Correct mention of Protobuf in RPC frameworks with mention of gRPC #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 133 commits into
base: main
Choose a base branch
from
Open

[Imported] Fix #493 : Correct mention of Protobuf in RPC frameworks with mention of gRPC #413

wants to merge 133 commits into from

Conversation

ido777
Copy link
Owner

@ido777 ido777 commented Apr 6, 2025

Imported from donnemartin/system-design-primer#494

Original author: @aymec

See #493

donnemartin and others added 30 commits December 3, 2017 07:09
@donnemartin
Update Japanese translation link (#118)
c3f080f
@koudaiii @donnemartin
ja: Fix typo (#119)
a4973a0
@donnemartin
Make some minor wording/formatting changes (#120)
748944c
@fluency03
add Twitter Handles 3,000 Images Per Second
dd124c4
@fluency03 @donnemartin
Add Netflix in Company Architectures (#122)
11b9d72
@donnemartin
Add Vietnamese translation link (#128)
8702199
@fluency03 @donnemartin
Add Scaling Uber in Company Architecture (#123)
156a67e
@donnemartin
Update master-slave section anchor (#129)
ebcec73
@fluency03 @donnemartin
Add Facebook Live Streams (#125)
0263906
@donnemartin
Update contributing guidelines - PR squash (#135)
12946d3
@hakaari @donnemartin
Update re:Invent url (#137)
61bc6f7
@fluency03
Merge branch 'master' into add-twitter
e86ed77
@kevingo @donnemartin
Add Traditional Chinese translation (#133)
9712a12
@kevingo @donnemartin
zh-TW: Add proper line break to links (#139)
82868d3
@donnemartin
Add Greek translation link (#140)
7272a9b
@donnemartin
Convert all .py files to be valid Python (#98)
de3c13c
@robertding @donnemartin
zh-Hans: Fix typos (#141)
94c158e
@donnemartin
Add Spanish translation link (#142)
7c38532
@donnemartin
Add missing colons to class methods (#143)
3079562
@donnemartin
Add missing self variables to Deck of Cards solution (#145)
d90b562
@donnemartin
Add deque import to Social Graph solution (#147)
7e316ce
@donnemartin
Change LARGE to VehicleSize.LARGE in parking lot solution (#146)
f552598
@htkuan @donnemartin
zh-TW: Fix comment format (#155)
f038dbb
@donnemartin
Fix coding errors (#149)
d7d0e9d
@hulikau @donnemartin
Fix dict KeyError (#152)
f05373a
@hulikau @donnemartin
Fix dict KeyError (#153)
7a4dbb1
@donnemartin
Adding missing self variable (#158)
4a0d7fb
@donnemartin
Add missing enum imports (#157)
02a20c6
@donnemartin
Change variable seller to category in Mint solution (#159)
2368ee0
@b7wch @donnemartin
zh-Hans: Fix typo (#161)
38cb1be
neesara and others added 25 commits July 3, 2020 21:22
@neesara
Resolve #164 - Fix phrasing with availability and partition tolerance (…
a61d62f 
…#350)
@sainadh-d
Check dependencies in Ebook gen script (#406)
7b495be
@kevinliu23
Fix typo: Change replication to federation (#418)
c55c941
@kof-f
Update Twitter back-of-the-envelope calculations (#414)
8bb74cd
@Agade09
Fix typos in Twitter and web crawler exercises (#438)
071d84d
@nacharya-msft
Fix #313: Clarify availability patterns (#439)
a23ab1e
@rahilsh
Add system design template link (#433)
7ee4c1d
@youngchul
kr: Fix Korean translation link in language index (#340)
92014a4
@vemikhaylov
Fix Mint exercise bugs and typos (#409)
6cce656
@John-Richardson
Remove redundant SQL index in Pastebin exercise (#405)
eae7ed2
@morenoh149
Additional question, build an exchange
fba0504 
fixes donnemartin#281
@hiscodesmells
Add CAP theorem video link (#400)
d47546b
@joilson-cisne
Fix loop bug in deck of cards exercise (#396)
572ad46
@ganesshkumar
Update dead links (#321)
8c19ffc
@varshavjm
Add links for latency based and geolocation based routing (#319)
cd7907e
@noebrito
Clarify CDN advantages (#310)
50e9d7a
@ad-m
Change disk to HDD for clarity (#295)
e9f62f1
@donnemartin
Update README.md
22054f4
@donnemartin
Resolve #281: Add design stock exchange links (#441)
c0330a0 
* Additional question, build an exchange

fixes donnemartin#281

* Update README.md

Co-authored-by: Donne Martin <[email protected]>
@donnemartin
Remove extraneous __init__.py (#393)
cca3e03
@danieljl
Remove Imgur dependency by storing images locally (#168)
f655458
@iravitejakumar
Fix #335: Update OSI image to Open Systems Interconnection (#447)
2fa0808
@serima
Fix translations link in PR template (#451)
a910106
@peteryao7
Update broken HBase architecture link (#481)
a078026
@aymec
Correct mention of Protobuf in RPC framworks with mention of gRPC (#493)
50efdd3
@Copilot Copilot AI review requested due to automatic review settings April 6, 2025 20:37
@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @tvladyslav

Thats right, Protobuf is responsible for interface description. It is not a standalone RPC solution.

Copilot
Copilot AI reviewed Apr 6, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported review by @duynguyenhoang

State: APPROVED

LGTM

@ido777 ido777 force-pushed the imported-pr-494 branch from 9338f16 to 50efdd3 Compare May 14, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.