forked from donnemartin/system-design-primer
-
Notifications
You must be signed in to change notification settings - Fork 2
[Imported] Latency numbers: remove conversion to throughput #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ido777
wants to merge
102
commits into
main
Choose a base branch
from
imported-pr-427
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Japanese translation is ambiguous about “vertical scaling” means scaling out or scaling up. - The word “expensive” is missing in the Japanese translation.
- Fix mistranslation of parallel structure. (not information/blacklist/limit, but hide/blacklist/limit)
* JA: Fix mistranslation in Horizontal scaling section - The Japanese translation is ambiguous about “vertical scaling” means scaling out or scaling up. - The word “expensive” is missing in the Japanese translation. * ja: Fix mistranslation in "Horizontal scaling"
Remove conversion of latency numbers to throughput. This is misleading for two reasons: 1. Latency and throughput are not computable from each other. For example: if I know it takes 1 second to turn on the hose, get 1 liter of water, and turn it off, I cannot conclude that the maximum rate I can get water out of the hose is 1 liter per second (though I can conclude it's more than that). 2. The throughput estimates seem suspect, in and of themselves. These are great numbers to know, of course, but need to be backed by a separate source. (This'll be extra important if and when this guide includes information about, say, GPUs, which are optimized for throughput).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
anandfresh
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported from donnemartin/system-design-primer#427
Original author: @psanan
Remove conversion of latency numbers to throughput.
This is misleading for two reasons: