-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registration page #1143
base: master
Are you sure you want to change the base?
Registration page #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @H9660, sorry for the delay - I'm only able to check the PRs once per week. Regarding your changes, it look OK, just remove your connection string with credentials.
a004ca6
to
2b9297e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the work on my machine, registration workflow works. Nice work 👍
By the way, could you check my other PR: #1145 ?
Yeah sure. But who is the maitainer of this repo. Because his approval is needed for merging. |
@H9660 Is this merged yet or not? |
Not yet bro. Can you contact @salahlalami regarding this? |
@salahlalami Any update on this? |
Hi @salahlalami . Do we have any update on this? I think this is an important issue that we can fix for better user experience. |
@lukasz1mroz any Update on this? |
Hi @shawnyplayz I have created the PR just waiting for @salahlalami approval. |
Thanks! |
Hi @salahlalami Could you please review and merge my pull request #1143? I have tested the changes and ensured all the checklists are met. Thank you! |
Description
Please provide a brief description of the changes or additions made in this pull request.
Related Issues
If this pull request is related to any issue(s), please list them here.
Steps to Test
Provide steps on how to test the changes introduced in this pull request.
Screenshots (if applicable)
If your changes include visual updates, it would be helpful to provide screenshots of the before and after.
Checklist