Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration page #1143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Registration page #1143

wants to merge 3 commits into from

Conversation

H9660
Copy link

@H9660 H9660 commented Jul 6, 2024

Description

Please provide a brief description of the changes or additions made in this pull request.

Related Issues

If this pull request is related to any issue(s), please list them here.

Steps to Test

Provide steps on how to test the changes introduced in this pull request.

Screenshots (if applicable)

If your changes include visual updates, it would be helpful to provide screenshots of the before and after.

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

@H9660 H9660 mentioned this pull request Jul 6, 2024
6 tasks
@H9660 H9660 changed the title Registeration page Registration page Jul 6, 2024
@H9660 H9660 mentioned this pull request Jul 11, 2024
backend/.env Outdated Show resolved Hide resolved
Copy link
Contributor

@lukasz1mroz lukasz1mroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @H9660, sorry for the delay - I'm only able to check the PRs once per week. Regarding your changes, it look OK, just remove your connection string with credentials.

Copy link
Contributor

@lukasz1mroz lukasz1mroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the work on my machine, registration workflow works. Nice work 👍

By the way, could you check my other PR: #1145 ?

@H9660
Copy link
Author

H9660 commented Jul 16, 2024

Tested the work on my machine, registration workflow works. Nice work 👍

By the way, could you check my other PR: #1145 ?

Yeah sure. But who is the maitainer of this repo. Because his approval is needed for merging.

@AhsanSarwar0413
Copy link

@H9660 Is this merged yet or not?

@H9660
Copy link
Author

H9660 commented Jul 20, 2024

@H9660 Is this merged yet or not?

Not yet bro. Can you contact @salahlalami regarding this?

@H9660
Copy link
Author

H9660 commented Jul 26, 2024

@salahlalami Any update on this?

@H9660
Copy link
Author

H9660 commented Aug 8, 2024

Hi @salahlalami . Do we have any update on this? I think this is an important issue that we can fix for better user experience.

@shawnyplayz
Copy link

@lukasz1mroz any Update on this?

@H9660
Copy link
Author

H9660 commented Sep 3, 2024

@lukasz1mroz any Update on this?

Hi @shawnyplayz I have created the PR just waiting for @salahlalami approval.

@shawnyplayz
Copy link

Thanks!

@H9660
Copy link
Author

H9660 commented Oct 12, 2024

Hi @salahlalami

Could you please review and merge my pull request #1143? I have tested the changes and ensured all the checklists are met.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants