Skip to content

Considering primary data that start before simulation. #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from
Draft

Considering primary data that start before simulation. #1038

wants to merge 12 commits into from

Conversation

staudtMarius
Copy link
Member

@staudtMarius staudtMarius commented Nov 20, 2024 •
edited
Loading

Resolves #1034

@staudtMarius staudtMarius added the enhancement New feature or request label Nov 20, 2024
@staudtMarius staudtMarius self-assigned this Nov 20, 2024
@staudtMarius staudtMarius removed the request for review from sebastian-peter November 20, 2024 08:08
staudtMarius and others added 9 commits November 20, 2024 13:57
@staudtMarius
Improving code.
e6fb264
@staudtMarius
Adding test in PrimaryServiceWorkerSpec.
824082c
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
b18ab34 
…re-simulation
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
e06ea1a 
…re-simulation
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
31f2106 
…re-simulation

# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/service/primary/PrimaryServiceWorker.scala
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
9edb22e 
…re-simulation

# Conflicts:
#	CHANGELOG.md
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
0126fb0 
…re-simulation

# Conflicts:
#	CHANGELOG.md
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
32e5652 
…re-simulation
@staudtMarius
Improving the call to get the previous value option in `PrimaryServic…
1cca8e8 
…eWorker`.
@staudtMarius staudtMarius marked this pull request as ready for review March 5, 2025 14:30
@sebastian-peter sebastian-peter self-requested a review March 11, 2025 10:47
sebastian-peter
sebastian-peter reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting in the effort. I've been looking through the code and kept thinking that we should just integrate this into getTimeKeysAfter and make it the PSDM's job.... That'd make it less complicated here.

@staudtMarius
Copy link
Member Author

I will create an PSDM issue for this.

@staudtMarius staudtMarius mentioned this pull request Mar 11, 2025
Open
@staudtMarius staudtMarius marked this pull request as draft March 11, 2025 13:17
@staudtMarius staudtMarius added the blocked externally Progress blocked by outside resource label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter left review comments

@danielfeismann danielfeismann Awaiting requested review from danielfeismann

At least 1 approving review is required to merge this pull request.

Assignees

@staudtMarius staudtMarius

Labels
blocked externally Progress blocked by outside resource enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider PrimaryData that start before simulation
2 participants
@staudtMarius @sebastian-peter