Skip to content

Fixed bugs in congestion management. #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 6, 2025
Merged

Fixed bugs in congestion management. #1394

merged 11 commits into from
Jun 6, 2025

Conversation

staudtMarius
Copy link
Member

@staudtMarius staudtMarius commented May 20, 2025 •
edited
Loading

Resolves #1393
Resolves #1395

@staudtMarius staudtMarius self-assigned this May 20, 2025
@staudtMarius staudtMarius added the bug Something isn't working label May 20, 2025
@staudtMarius staudtMarius changed the title Fixed bug in returned next tick after congestion management. Fixed bugs in congestion management. May 20, 2025
danielfeismann
danielfeismann requested changes May 22, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the question on completeness of the test cases.

@staudtMarius
Copy link
Member Author

staudtMarius commented May 23, 2025 •
edited
Loading

@danielfeismann Short notice, I moved the test CongestedComponentsSpec to be in line with the class structure.

staudtMarius and others added 4 commits May 27, 2025 08:04
@staudtMarius
Merge branch 'dev' into ms/#1393-fix-bug-in-returned-next-tick-after-…
55dcafb 
…congestion-management
@staudtMarius
Merge branch 'dev' into ms/#1393-fix-bug-in-returned-next-tick-after-…
b197882 
…congestion-management

# Conflicts:
#	src/test/scala/edu/ie3/simona/agent/grid/congestion/CongestionTestBaseData.scala
@staudtMarius
Merge branch 'dev' into ms/#1393-fix-bug-in-returned-next-tick-after-…
b6a5af2 
…congestion-management
@staudtMarius
Merge branch 'dev' into ms/#1393-fix-bug-in-returned-next-tick-after-…
3672d0e 
…congestion-management

# Conflicts:
#	CHANGELOG.md
@staudtMarius staudtMarius requested review from danielfeismann and removed request for danielfeismann June 4, 2025 10:14
danielfeismann
danielfeismann approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit 28c6e4a into dev Jun 6, 2025
3 checks passed
@danielfeismann danielfeismann deleted the ms/#1393-fix-bug-in-returned-next-tick-after-congestion-management branch June 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

Assignees

@staudtMarius staudtMarius

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bug in CongestionResult values Fix bug in returned next tick after congestion management
2 participants
@staudtMarius @danielfeismann