feat: preserve metadata when handling blobs; refactor storage_utils #8713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rather consequential refactor. Moves the utility methods (store_file(), remove_from_storage(), etc) out of the Storage subclass. They are now only in storage_utils.py. Drops the StoredObjectStorageMixin, instead moving the Storage-like parts directly into StoredObjectStagedBlobStorage. The CustomS3Storage class is dropped, at least for now.
|
Work to reconcile this with #8784 is in progress - merging this as it is to try to avoid future merge nightmares. Fixups may still be necessary and will be treated as future work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.