feat: add liaison coordinators, remove from restrictions #9055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to confirm what is actually needed, but without these users may be able to create/edit LS's they can't actually fill in.
feat: adjust liaison statement to/from group choices based on role
fix: remove authorized persons from sdo groups
fix: remove liaison_contact and liaison_cc_contact Role objects
* feat: liaison coordinators * fix: give liaison coordinator the ability to send incoming
* refactor: CharField for LS from_contacts * refactor: replace from_contact field * style: copyrights + ruff * fix: listify in the right place * refactor: better validator * refactor: use new from_contact field; fix lint * fix: cleanup * feat: default addresses for roles * chore: update liaisons.resources from_name and to_name were removed in 2015!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9055 +/- ##
==========================================
+ Coverage 88.72% 88.75% +0.02%
==========================================
Files 320 320
Lines 41771 41788 +17
==========================================
+ Hits 37061 37087 +26
+ Misses 4710 4701 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jennifer-richards
approved these changes
Jun 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.