Skip to content

fix: Include text to set/update photo #9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025
Merged

Conversation

richsalz
Copy link
Collaborator

This could be the only fix that #2209 (created 2017) is going to get, but I didn't mark it as fixes it.

This PR adds "Email [email protected] to update your picture", whether or not there is a photo available.

@rjsparks
Copy link
Member

Should we restrict showing this to people with some Role?
I think if this appears generally, it could put a lot of demand on the secretariat.

(I still think we should move to gravatar or the like rather than host our own pictures fwiw)

@richsalz
Copy link
Collaborator Author

richsalz commented Jul 20, 2025 via email

Copy link

codecov bot commented Jul 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (f380b1a) to head (682dac1).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9186      +/-   ##
==========================================
- Coverage   88.74%   88.74%   -0.01%     
==========================================
  Files         321      320       -1     
  Lines       41853    41656     -197     
==========================================
- Hits        37144    36969     -175     
+ Misses       4709     4687      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks
Copy link
Member

we have discussed it several times already. It's better done as a tools call topic

@richsalz
Copy link
Collaborator Author

I know we have talked about it a lot, I was asking if we have consensus. I'll take your comment as "no" So can we put it on the agenda to get a decision?

@richsalz
Copy link
Collaborator Author

I agree that showing the text if the person has a role is the right trade-off of convenience vs load-on-secretariat, so this is a fix and Gravatar is a separate future item.

@rjsparks rjsparks merged commit b766eaf into ietf-tools:main Jul 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants