Skip to content

Conversation

@Sreyanth
Copy link

fix #9905 - show dark color text on timeline bar in both light & dark modes

…k mode (ietf-tools#9905)

fix ietf-tools#9905 - show dark color text on timeline bar in both light & dark modes
@jennifer-richards
Copy link
Member

@larseggert IIRC an aim of the bootstrap5 reskin was to avoid custom CSS as much as possible. Thoughts about adding the custom color here rather than finding something in the --bs-* variables (or some other fix)?

@rjsparks
Copy link
Member

These changes, so far, only affect the text color:
image
The colors of the bars themselves should also be reconsidered in this mode - they aren't painful in light-mode, but they are eye-stabbing in dark-mode.

The lightmode alternates between bootstrap's warning and info colors if I read the scss correctly, but I wonder if the way we're collecting them causes them to not follow changes to darkmode correctly. Re-appealing to @larseggert for a look.

@Sreyanth
Copy link
Author

Thanks for the comments! For this PR I intentionally kept the scope small and only updated the text colors (so the labels are at least readable), reusing the existing variables to keep things consistent with the rest of the dark-mode theme.

I agree that the timeline bar colors themselves could use a broader rethink for dark-mode. I’m happy to dig into that if that’s a direction you’d like to pursue. Looking forward to @larseggert's guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

darkmode timeline colors are hard to see

3 participants