Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Docker image to GitHub registry #2642

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Jan 3, 2025

When a PR gets merged to the Main branch, or when a tag is created, a Docker image should be published to the GitHub-provided registry.

@guusdk guusdk requested a review from Fishbowler January 3, 2025 14:48
@guusdk guusdk force-pushed the docker-registry-publication branch from b63c42f to 00996cf Compare January 3, 2025 14:51
@guusdk
Copy link
Member Author

guusdk commented Jan 3, 2025

@Fishbowler I don't really know what I'm doing here. I mostly copied your work. Does this need any configuration in the repository (secrets?)

@guusdk guusdk requested review from akrherz and dwd January 3, 2025 14:52
@guusdk guusdk force-pushed the docker-registry-publication branch from 00996cf to 83cb9aa Compare January 3, 2025 14:54
@guusdk
Copy link
Member Author

guusdk commented Jan 3, 2025

For posterity, @Fishbowler remarked here that the DockerHub publication that is being replaced in this PR was never used by Ignite.

Copy link
Member

@Fishbowler Fishbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guusdk guusdk merged commit 94f31ba into igniterealtime:main Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants