OF-2760: Fix MSSQL date/time column

[guusdk]

The Transact-SQL timestamp data type is different from the timestamp data type defined in the ISO standard. In MSSQL, timestamp is a synonym for the rowversion data type.

[gemini-code-assist]

Hello @guusdk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue with the TIMESTAMP data type in MSSQL. According to the description, the Transact-SQL timestamp data type is different from the ISO standard timestamp data type. In MSSQL, timestamp is a synonym for the rowversion data type. To resolve this, I've changed the data type of the retiredAt column in the ofMucRoomRetiree table from TIMESTAMP to DATETIME in both the initial database schema and the upgrade script.

Highlights

• MSSQL Data Type Correction: The TIMESTAMP data type in MSSQL is actually a rowversion. This PR corrects the schema to use DATETIME for date/time storage.
• Schema Update: The ofMucRoomRetiree table's retiredAt column is updated to use DATETIME.
• Upgrade Script: The upgrade script for MSSQL is also updated to reflect the data type change for retiredAt.

Changelog

• distribution/src/database/openfire_sqlserver.sql
  • Changed the data type of the retiredAt column in the ofMucRoomRetiree table from TIMESTAMP to DATETIME.
• distribution/src/database/upgrade/36/openfire_sqlserver.sql
  • Changed the data type of the retiredAt column in the ofMucRoomRetiree table from TIMESTAMP to DATETIME in the upgrade script.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

SQL was initially developed at IBM in the early 1970s. The original name was SEQUEL (Structured English Query Language).

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where the TIMESTAMP data type in MSSQL was being incorrectly used, as it's actually a synonym for ROWVERSION. The changes replace TIMESTAMP with DATETIME to align with the intended date/time storage. The changes look good overall.

Summary of Findings

• Data type correction: The pull request correctly identifies and rectifies the misuse of the TIMESTAMP data type in MSSQL, replacing it with DATETIME for accurate date/time representation.

Merge Readiness

The pull request appears to be ready for merging. The changes are straightforward and address a specific issue related to data type usage in MSSQL. Since there are no critical or high severity issues, and the changes are small, I recommend that the pull request be merged after another review. I am unable to directly approve the pull request, and that users should have others review and approve this code before merging.