fixes #373: Separate stanza parsing from database loading #374
+48
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
force-pushed
the
373_stanza-parsing
branch
from
25de93f to
d0fa954
Compare
Member
Author
|
Rebased. |
guusdk
force-pushed
the
373_stanza-parsing
branch
from
d0fa954 to
c0f0fe6
Compare
Member
|
Could there be memory allocation concerns with the database query filling up string stanzas to later parse? The previous code may be allowing this to throttle itself by having to iterate over the database result as the database result is materialized? |
Member
Author
|
That's possible, but I wonder if it is wildly different from the amount of memory being consumed by the parsed XMPP stanzas that were constructed 'on the fly' prior to this change. After this change, those stanzas are still being generated. Whenever a raw string is being converted into a stanza, that string is deallocated. I'm guessing that the total memory consumption is roughly the same. |
By not parsing database content immediately, this parsing can be done after the database connection has been released. This should reduce resource contention.
guusdk
force-pushed
the
373_stanza-parsing
branch
from
c0f0fe6 to
754efed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not parsing database content immediately, this parsing can be done after the database connection has been released. This should reduce resource contention.