-
Notifications
You must be signed in to change notification settings - Fork 50
Add DACCS and CCS infrastructure model #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=======================================
- Coverage 74.7% 74.7% -0.1%
=======================================
Files 270 272 +2
Lines 22312 22463 +151
=======================================
+ Hits 16676 16784 +108
- Misses 5636 5679 +43
🚀 New features to boost your workflow:
|
|
Thanks for starting this draft! Some quick reactions—these may be off the mark, since I am just guessing by looking at the Git history and changes:
Of course, I'm happy to help or bring in colleagues on any or all of these points. |
|
Thanks for the PR on the DAC and CCS :) |
a3e9675 to
9a7ba59
Compare
01d3815 to
56ca748
Compare
|
@macflo8 and I discussed that it is important to merge this PR in order to (a) reduce #235 to zero or few commits, such that that PR can be closed, and (b) allow other work to proceed from
|
Input changes by year_act rather than year_vtg.
This is the script to modify ssp setup to feasibly run low_overshoot scenarios. Important to note that modification to share constraints for end-user technologies for the transport sector is omitted here. I suggest that this is performed in the transport model so if there are updates from their side, this script does not accidentally remove the updates.
Please note that the location of ccs setup data is hardcoded in this function. Please edit according to user's data path
- Apply `ruff format`. - Address format check errors or add exclusions. - Address or add mypy exclusions.
- Register new modes - Transfer original meth_h2 mode parametrization to new modes - Delete old meth_h2 mode parametrization
56ca748 to
21f3de4
Compare
- Apply ruff format 0.11.5 - Comment out unused variables - Ignore C901
Use ssp_user_data for cost tool data input
Convert ssp string to lower case for DAC-CCS input file name definition
Replace MESSAGE_ITEMS with MESSAGE.items
- Include add_dac module and add_ccs_script() in autosummary documentation. - No docstrings; cf. #444.
21f3de4 to
67854b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ywpratama and @macflo8 for the work here.
I did the following:
- Opened #444 to note the need for a follow-up PR that adds the missing documentation.
- Reworded some commit messages to match the code style (capitalization, typos).
- Added one commit to mention the new module and tested function in the “What's new,” as required by the PR checklist.
With these, and the above caveats, we can now merge this.
|
Thanks @khaeru for adding the missing pieces required for the merge! |
- Include add_dac module and add_ccs_script() in autosummary documentation. - No docstrings; cf. #444.
This PR adds DACCS and modifies the CCS infrastructure representation in MESSAGEix for ScenarioMIP. It includes a set of functions to perform the task, as well as the necessary data provided in YAML files. Currently, several functions still need docstrings for proper documentation.
How to review
PR checklist
Add, expand, or update documentation.Deferred → Document and improve.tools.add_dac#444