Skip to content

Conversation

@khaeru
Copy link
Member

@khaeru khaeru commented May 13, 2025

Parallel to iiasa/ixmp#576.

How to review

  • Read the diff.
  • Note that the CI checks all pass. In particular look at this workflow run from the 'pull_request' trigger, and not the failed jobs from 'pull_request_target'.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A; CI changes only
  • Update release notes.
  • (After approval, before merge) Drop the TEMPORARY commit.

khaeru added 2 commits May 13, 2025 10:43
- In "pytest" CI workflow
- In ci/rtd-requirements.txt
- Project URLs: use sentence case and recognized names, adjust order.
- Replace "License ::" classifier with license=… field per build backend
  recommendation.
@khaeru khaeru added this to the 3.11 milestone May 13, 2025
@khaeru khaeru self-assigned this May 13, 2025
@khaeru khaeru added ci Continuous integration IXMP4Backend ixmp4 via ixmp.IXMP4Backend labels May 13, 2025
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.0%. Comparing base (fc8f9e0) to head (ee8c9fc).
Report is 4 commits behind head on main.

Current head ee8c9fc differs from pull request most recent head 7e0a756

Please upload reports for the commit 7e0a756 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #941     +/-   ##
=======================================
+ Coverage   90.6%   96.0%   +5.3%     
=======================================
  Files         53      53             
  Lines       4987    4988      +1     
=======================================
+ Hits        4521    4791    +270     
+ Misses       466     197    -269     

see 12 files with indirect coverage changes

Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, too, lgtm :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder whether the same is necessary in ixmp, but I don't see ixmp4 in our RTD requirements file there :)

@khaeru khaeru merged commit 6ee45ca into main May 13, 2025
9 of 25 checks passed
@khaeru khaeru deleted the ixmp4-0.10 branch May 13, 2025 09:54
ywpratama pushed a commit to ywpratama/message_ix that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration IXMP4Backend ixmp4 via ixmp.IXMP4Backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants