Skip to content

Conversation

@khaeru
Copy link
Member

@khaeru khaeru commented Jun 10, 2025

  • Simplify language.
  • Improve maths formatting for clarity.
  • Improve code examples for clarity.
  • Update/check show_plot() for current plotnine.
  • Fix some typos.
  • Use semantic line breaks.

How to review

  • Read the diff.
  • Note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@khaeru khaeru self-assigned this Jun 10, 2025
@khaeru khaeru added enh New features & functionality reporting docs Documentation tutorials Westeros and Austrian tutorials labels Jun 10, 2025
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.4%. Comparing base (33edac8) to head (e0156a9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #953     +/-   ##
=======================================
- Coverage   96.6%   96.4%   -0.3%     
=======================================
  Files         60      60             
  Lines       5135    5135             
=======================================
- Hits        4965    4954     -11     
- Misses       170     181     +11     

see 1 file with indirect coverage changes

Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without looking at the tests in more detail (and so without understanding why they're failing), I'll approve this PR in case you want to get it to main before tomorrow's workshop session.

Please note that if you want to get the docs build to pass, you can do the same as I did for ixmp: pin pandas to 2.2.3 in doc/requirements.in and let uv compile doc/requirements.txt again.

Comment on lines 47 to 48
" 2. Sum across the `\"technology\"` dimension, and finally\n",
" 3. Select the single value for the `\"year\"` 720.\n",
" 2. Select the single value for the `\"year\"` 720.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to now be

1.
2.
2.

Is that on purpose or just not finished yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just not finished yet?

This. I also meant to open the PR as a draft and leave it until after I present tomorrow and possibly notice further typos.

@khaeru khaeru force-pushed the enh/report-tutorial-2025-06 branch 2 times, most recently from de2428b to 59e0bec Compare June 10, 2025 13:56
khaeru added a commit that referenced this pull request Jun 10, 2025
@khaeru khaeru force-pushed the enh/report-tutorial-2025-06 branch from 59e0bec to 9fc4caa Compare June 10, 2025 14:53
@khaeru khaeru force-pushed the enh/report-tutorial-2025-06 branch from 9fc4caa to e0156a9 Compare September 15, 2025 14:26
@khaeru
Copy link
Member Author

khaeru commented Sep 16, 2025

Merging despite 2 failing checks:

  • The codecov/project failure seems to be spurious, as no code is changed here that would either increase or reduce coverage.
  • The macos-latest tutorials failure is flaky: different tutorials have timed out on each of 4 runs.

@khaeru khaeru merged commit 79e8809 into main Sep 16, 2025
78 of 88 checks passed
@khaeru khaeru deleted the enh/report-tutorial-2025-06 branch September 16, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation enh New features & functionality reporting tutorials Westeros and Austrian tutorials

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants