-
Notifications
You must be signed in to change notification settings - Fork 166
Update westeros_report.ipynb for 2025-06 workshop #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
=======================================
- Coverage 96.6% 96.4% -0.3%
=======================================
Files 60 60
Lines 5135 5135
=======================================
- Hits 4965 4954 -11
- Misses 170 181 +11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without looking at the tests in more detail (and so without understanding why they're failing), I'll approve this PR in case you want to get it to main before tomorrow's workshop session.
Please note that if you want to get the docs build to pass, you can do the same as I did for ixmp: pin pandas to 2.2.3 in doc/requirements.in and let uv compile doc/requirements.txt again.
| " 2. Sum across the `\"technology\"` dimension, and finally\n", | ||
| " 3. Select the single value for the `\"year\"` 720.\n", | ||
| " 2. Select the single value for the `\"year\"` 720.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to now be
1.
2.
2.
Is that on purpose or just not finished yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just not finished yet?
This. I also meant to open the PR as a draft and leave it until after I present tomorrow and possibly notice further typos.
de2428b to
59e0bec
Compare
59e0bec to
9fc4caa
Compare
9fc4caa to
e0156a9
Compare
|
Merging despite 2 failing checks:
|
show_plot()for current plotnine.How to review
PR checklist
Add or expand tests;coverage checks both ✅