Conversation
|
Hi! Thanks for contributing to this repository. |
|
@Monal5031 pls check PR #197 let me know if there is still some error |
|
@aashutoshrathi @Monal5031 pls justify what is the exact error in my PR |
|
@NishantTanwar The problem is that you have use space indentations while in this repo we follow tabspaces for c and cpp files. Use tab indentation to pass all the tests. |
Monal5031
left a comment
There was a problem hiding this comment.
Please remove the .idea files.
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Please remove these .idea files
|
@NishantTanwar Please make changes. |
|
Yeah. I am updating it. |
|
Please review @Monal5031 I have updated. |
|
Remove all unwanted files, make your indentation to tabs and add a new line to the end of the file, as soon as Travis Checks become successful, we will merge it. |
|
But I guess I have given proper indentation to tabs and also removed the unwanted files |
|
No, your PR edits 6 files, while it should edit only 3 (including .gitignote). |
There was a problem hiding this comment.
Please undo this change, as it is not part of your PR.
2017/JULY/JULY17/EXPTREE/EXPTREE.cpp
Outdated
There was a problem hiding this comment.
After which line number?
| *.class | ||
| *.pyc | ||
| *.html | ||
| .idea/ |
There was a problem hiding this comment.
Rather simply delete the .idea files for now and in another PR you can do this 😉
|
ping @NishantTanwar Its been 5 days since this PR was last updated, please update it before time. |
|
@Monal5031 I am not able to get those identation errors hence was not able to update it. I have reviewed my code many times and it seems that I have given tab indentation and not space identation |
|
@NishantTanwar If you want some help in indenting the code properly you can use but first you need to install coala using This will tab indent the code itself. |
|
@Monal5031 I added a new line at the end but still didn't work. |
|
@NishantTanwar Did you try indenting the code using coala, because the space indentation error still persists. |
Fixes #194
EXPTREE (JULY 17) [CPP].