-
-
Notifications
You must be signed in to change notification settings - Fork 131
Symbols API v3 #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wasabii
wants to merge
20
commits into
develop
Choose a base branch
from
symbols3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Symbols API v3 #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to call some private methods.
Imported emit logic and tests.
…as missing out on types not in CoreLib, but still present in identified ystem assemblies. But these are MapXML, so they should allow selection from any reference. Connect existing Import/Export code to new Symbol code, though we are still not using Symbol code widely. We're resolving back to Type immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduction of the Symbols API. This is a parred down version of the symbols2 branch, removing the actual usage of TypeSymbol and such from Runtime. Instead, only CoreLib and Tests are introduced, along with some hookup logic for Importer/Exporter. This should be able to get tested easier than the full feature done in symbols2. That will come next.