RFC: Add Quantity::as_ and Quantity::cast for changing the underlying storage type. #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first go at something helping with #293.
The restriction to
$units<V>
instead ofU: Units<V>
seems a bit weird, but it was the only way I saw to enforce that the same set of base units would be used for the conversion. (The more general version fails with trait bound errors as e.g. thef32
base units do not implementUnits<i32>
and without generic associated types there is no way to ask aUnits<V>
implementor for its equivalentUnits<W>
implementor AFAIU.)Finally, while I added minimal doc tests, I am not sure where actual unit tests should end up as this involves at least two storage types by definition.