feat: impl Error for TryFromError #519
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
error::Error
trait on theTryFromError
enum.The only other error type in
uom
isParseQuantityError
, which already implementsError
. I copied the same structure for implementingError
on this type, modifying the error messages appropriately.The reason I am proposing this change is because I recently found myself wanting to write a function like this:
However, this function does not compile, and results in the following error:
This PR resolves this issue.
This is my first contribution to
uom
, so if I have missed anything important, please let me know.