Skip to content

Hacktober fest raje pr1 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rajeshsgr
Copy link

Code Snippet for File Rename

/*
* MIT License
*
* Copyright (c) 2017-2022 Ilkka Seppälä

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Copyright (c) 2017-2024 Ilkka Seppälä

@Ritabrata1080
Copy link

Changes LGTM ✅.

Shall the copyright year be 2017-2024 or 2017-2022?
Please confirm @iluwatar

Copy link

@Ritabrata1080 Ritabrata1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all the commits to a single commit.

@rajeshsgr
Copy link
Author

I have done all the changes, the build is failing for a file which i have not changed or worked on

@Ritabrata1080
Copy link

I have done all the changes, the build is failing for a file which i have not changed or worked on

Approved. Please squash the commits once.

File Rename Snippet

Code Snippet to Rename a File

Test class for Code Snippet to Rename a File
@rajeshsgr rajeshsgr force-pushed the hacktober-fest-raje-pr1 branch from d9441df to c443228 Compare October 14, 2024 20:36
@rajeshsgr
Copy link
Author

Squashed, please check

@Ritabrata1080
Copy link

This checks might be failing due to addition of main() in the code. I think only driver code is allowed to be pushed and not the main method.

@rajeshsgr
Copy link
Author

I have removed the main, it fails when it compiles - MultiArrayConcatenationSnippet.java and says it uses unchecked or unsafe operations. This is a file which i have not changed or worked on .

@Ritabrata1080
Copy link

I have removed the main, it fails when it compiles - MultiArrayConcatenationSnippet.java and says it uses unchecked or unsafe operations. This is a file which i have not changed or worked on .

I also faced many issues to get the scans successful. Not sure why MultiArrayConcatenationSnippet.java file compiled for me successfully. Is there any channel where we collaborators can connect?

@Ritabrata1080
Copy link

Also, could u plz review my PR #224?

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the following

Copy link

stale bot commented Dec 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale label Dec 4, 2024
Copy link

stale bot commented Jan 18, 2025

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants