Conversation
k1w1dev
force-pushed
the
fix/sonar-issues
branch
2 times, most recently
from
99628f1 to
c49a18b
Compare
Contributor
Author
|
@iluwatar Hi, would be keen to get some feedback on this whenever you get some time. Thank you :) |
…CiGJS70dLki&id=iluwatar_java-design-patterns related to "Refactor the code of the lambda to not have multiple invocations throwing the same checked exception." Also, updated the code to use Instant and Duration to deal with time instead of int. Added the awaitility library to perform assertions in test which is more reliable than using Thread.sleep directly to wait for events to happen.
…e method is not being tested but instead the new SimpleFileWriter(...) is.
…umber of individual params, which sonar did not like.
…wn even further but currently Sonar is happy.
…e methods are quite generic and not functional enough to be separated out.
|
iluwatar
approved these changes
May 4, 2024
Owner
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @k1w1dev for code |
Contributor
|
I couldn't determine any contributions to add, did you specify any contributions? @k1w1dev already contributed before to code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes majority of the high severity issues raised by Sonar. There's a few more left but the changes are already big enough for a review.
Fixes #2865