-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2373 feature add: Vertical Slice Architecture. #3136
base: master
Are you sure you want to change the base?
Conversation
…tible SLF4J and Logback versions
PR SummaryThis PR introduces the Vertical Slice Architecture design pattern. The application is organized by feature, each with its own models, services, repositories, and views. This improves modularity and reduces mocking needs. New files include models, services, repositories, views, tests, and updated documentation. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (22)
- a53c5d9: Merge branch 'iluwatar:master' into master
- b1c2f35: fix: prevent H2 shutdown warnings by disabling DB_CLOSE_ON_EXIT
- b12e751: fix: align logging dependencies with Spring Boot by excluding incompatible SLF4J and Logback versions
- 0a39bed: Merge branch 'iluwatar:master' into master
- 6d83016: Merge branch 'iluwatar:master' into master
- 7e775f3: Merge branch 'master' into master
- e704103: Merge branch 'master' into master
- 08b77c5: added file structure.
- 70fde67: Merge remote-tracking branch 'origin/master'
- c52566d: correction updated with pattern template.
- dda150f: Merge branch 'master' into master
- 72c9c87: Merge branch 'master' into master
- b84112d: Merge branch 'master' into master
- 0b160cb: Merge branch 'master' into master
- 4e0c2c2: Merge branch 'master' into master
- 24d5063: Added better explanation and updated README.md
- cf06c64: Merge branch 'iluwatar:master' into master
- c189ae9: added more context with example
- 272cb87: local variable in var declaration
- 1b130b1: App code coverage changes
- 3f1828a: fixed code smell
- 777a5dc: Vertical slice architecture #2373 add: Vertical Slice Architecture.
Files Processed (30)
- pom.xml (1 hunk)
- vertical-slice-architecture/README.md (1 hunk)
- vertical-slice-architecture/etc/vertical-slice-architecture.urm.png (0 hunks)
- vertical-slice-architecture/etc/vertical-slice-architecture.urm.puml (1 hunk)
- vertical-slice-architecture/pom.xml (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/App.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/Runner.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/customer/Customer.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/customer/CustomerRepository.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/customer/CustomerService.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/customer/CustomerView.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/order/OrderRepository.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/order/OrderService.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/order/OrderView.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/order/Orders.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/product/Product.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/product/ProductRepository.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/product/ProductService.java (1 hunk)
- vertical-slice-architecture/src/main/java/com/iluwatar/verticalslicearchitecture/product/ProductView.java (1 hunk)
- vertical-slice-architecture/src/main/resources/application.properties (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/AppTests.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/customer/CustomerServiceTest.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/customer/CustomerTest.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/customer/CustomerViewTest.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/order/OrderServiceTest.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/order/OrderViewTest.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/order/OrdersTest.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/product/ProductServiceTest.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/product/ProductTest.java (1 hunk)
- vertical-slice-architecture/src/test/java/com/iluwatar/verticalslicearchitecture/product/ProductViewTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
The build is failing. Please ensure that all the checks pass before requesting review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 0dc87ed: Merge branch 'master' into master
Added the Vertical Slice Architecture #2373. previous PR: #2828