Conversation
|
⏳ Analyzing changes in this PR... ⏳ This might take a few minutes, please wait 📥 CommitsAnalyzing changes from base (
📁 Files being considered (1)➕ localization/de/abstract-factory/README.md (1 hunk) autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (3)
Files Processed (2)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
Actionable Comments (0)
Skipped Comments (6)
-
localization/de/README.md [1-4]
readability: "Inconsistency in badge wording"
-
localization/de/README.md [14-15]
readability: "Language list and link consistency"
-
localization/de/README.md [19-24]
readability: "Intro copy consistency"
-
localization/de/README.md [37-37]
readability: "Terminology consistency"
-
localization/de/README.md [47-50]
readability: "Book section language and capitalization"
-
localization/de/README.md [54-54]
readability: "License phrasing"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 398d4f5: Create folder for Abstract Factory
Files Processed (3)
- localization/de/Abstract Factory (1 hunk)
- localization/de/README.md (2 hunks)
- localization/de/abstract-document/README.md (4 hunks)
Actionable Comments (1)
-
localization/de/abstract-document/README.md [88-92]
readability: "Narrative text inside code block breaks Java code snippet."
Skipped Comments (9)
-
localization/de/Abstract Factory [1-1]
maintainability: "Remove empty placeholder file or replace with a valid README."
-
localization/de/README.md [1-4]
readability: "Check German title and top-section localization."
-
localization/de/README.md [11-16]
readability: "Add language navigation links."
-
localization/de/README.md [37-37]
readability: "Verify list formatting and language consistency in new bullets."
-
localization/de/README.md [45-50]
readability: "Add book section; fix minor localization typos."
-
localization/de/README.md [54-54]
readability: "License phrasing"
-
localization/de/abstract-document/README.md [3-11]
readability: "Localize front-matter tags."
-
localization/de/abstract-document/README.md [238-245]
readability: "Clarify advantages/disadvantages section layout."
-
localization/de/abstract-document/README.md [246-249]
readability: "Remove/handle affiliate links in sources."
| // Weitere Eigenschaften und Methoden... | ||
| } | ||
| ``` | ||
| Als nächstes definieren wir ein Enum Property und eine Menge von Schnittstellen für Typ, Preis, Modell und Teile. Dies ermöglicht es uns, eine statisch aussehende Schnittstelle für unsere Car-Klasse zu erstellen. | ||
| Als nächstes definieren wir ein Enum `Property` und je eine Schnittstelle für Typ, Preis, Modell und Teile. So können wir eine statisch aussehende Schnittstelle für unsere Klasse `Car` erstellen. | ||
|
|
There was a problem hiding this comment.
Narrative explanations were inserted inside a Java code block, which will break syntax. Move these explanations outside the code block or convert to code comments.
There was a problem hiding this comment.
They are outside the code block
|
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- e71866f: Create README.md for Abstract Document
Files Processed (1)
- localization/de/abstract-factory/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (8)
-
localization/de/abstract-factory/README.md [19-21]
readability: "Grammatik und Stil verbessern"
-
localization/de/abstract-factory/README.md [23-23]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [25-29]
readability: "Bilingual content inconsistency"
-
localization/de/abstract-factory/README.md [31-31]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [35-35]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [39-39]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [172-172]
readability: "Übersetzung von Überschriften"
-
localization/de/abstract-factory/README.md [190-190]
readability: "Übersetzung von Überschriften"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 624e970: Translate README.md for Abstract Document to German
Files Processed (1)
- localization/de/abstract-factory/README.md (1 hunk)
Actionable Comments (1)
-
localization/de/abstract-factory/README.md [36-36]
typo: "Typo: 'Klassse' → 'Klasse'"
Skipped Comments (4)
-
localization/de/abstract-factory/README.md [40-40]
readability: "Bildpfad fehlerhaft: UML-Diagramm-Datei"
-
localization/de/abstract-factory/README.md [90-90]
readability: "Markdown-Codeblock falsch beendet"
-
localization/de/abstract-factory/README.md [146-146]
readability: "Ungenauigkeit im Beispielpfad"
-
localization/de/abstract-factory/README.md [199-205]
readability: "Formatter-Fehler: leere Bulletzeilen"
|
|
||
| Wikipedia sagt | ||
|
|
||
| > Das Abstract-Factory-Pattern dient zur Kapselung einer Gruppe einzelner Factories mit gemeinsamem Thema, wobei deren konkrete Klassse variabel bleibt. |
There was a problem hiding this comment.
Typo in German translation: 'Klassse' ist falsch geschrieben. Korrigiere zu 'Klasse'.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- b91d1f7: correct typo
Files Processed (1)
- localization/de/abstract-factory/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
-
localization/de/abstract-factory/README.md [89-89]
readability: "Inconsistent Orc/Ork terminology in sample code"
-
localization/de/abstract-factory/README.md [143-155]
readability: "Usage example has incorrect/type reference and naming"
|
1 participant
Issue #2275
What does this PR do?