Read Byte as u8, SignedByte as i8 #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also handle casting of Byte (u8) into other unsigned types.
Also handle casting of SignedByte (i8) into other signed types.
|
Thanks @fintelia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Byte values were read incorrectly as
u32instead ofu8, and SignedShort values were read incorrectly asi32instead ofi8.This PR does the following:
Type::BYTEas u8 values, and support casting Byte to other unsigned types viainto_u16,into_u32,into_u64,into_u16_vec,into_u32_vec, andinto_u64_vecmethods.Type::SBYTEas i8 valuesSimilar to #235, resolves some inconsistencies raised in #204.