Skip to content

Bump MSRV from 1.61.0 to 1.70.0 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Conversation

weiji14
Copy link
Contributor

@weiji14 weiji14 commented Mar 16, 2025

MSRV bump was accidentally reverted in 652721e / #257 and not reinstated.

Have verified using cargo msrv find that minimum supported version is indeed 1.70.0. Output from cargo msrv list:

  [Meta]   cargo-msrv 0.18.3

  ╭────────┬────────────────────────────────────────────────────────╮
  │ MSRV   │ Dependency                                             │
  ├────────┼────────────────────────────────────────────────────────┤
  │ 1.70.0 │ tiff, half                                             │
  ├────────┼────────────────────────────────────────────────────────┤
  │ 1.67.0 │ flate2                                                 │
  ├────────┼────────────────────────────────────────────────────────┤
  │ 1.61.0 │ jpeg-decoder                                           │
  ├────────┼────────────────────────────────────────────────────────┤
  │        │ weezl, crunchy, cfg-if, miniz_oxide, crc32fast, adler2 │
  ╰────────┴────────────────────────────────────────────────────────╯

Note: since there isn't a Cargo.lock file in this repo, I needed to pin half = { version = "=2.4.1" } in the Cargo.toml to ensure the correct MSRV of 1.70.0 was picked up, otherwise half=2.5.0 would result in an MSRV of 1.85.0.

Found using `cargo msrv find`, the `1.70.0` version is determined by `half=2.4.1` having an MSRV of 1.70.0.
@kornelski kornelski merged commit 36f7b3b into image-rs:master Mar 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants