-
Notifications
You must be signed in to change notification settings - Fork 680
Implement loop_count for AnimationDecoder Trait. #2716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: rayguo17 <[email protected]>
Signed-off-by: rayguo17 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems agreeable. (fyi, I'd rather we merge this PR to introduce the type and then I adjust #2672 where the AnimationDecoder trait was removed. It fits well with the is_animated field that got added there.)
Signed-off-by: rayguo17 <[email protected]>
Do you mind explain a bit on the change for AnimationDecoder in #2672 ? I look through the code, and seems to me the PR only change the implementation of the iterator, and still implementing AnimationDecoder. |
|
The PR replaces what |
|
Hey @197g , I wonder what is the release procedure of image crate? When do you plan to do the next release? |
|
Since the next planned to be new major bump (#2245), it may be a bit for the fully intended one (1st March?) to tie up the lose ends of animation. That said there were a few fixes in the underlying codecs and a bunch on tiff that might warrant doing a |
As described in #2715, This PR implements
loop_countfunction forAnimationDecoderTrait, currently there are three type (Gif, Webp and Apng) implementingAnimationDecoderTrait, so implementation on these specific format decoders are added.