Fixes a NPE when omeroAnnotations do not contain the pixelsID key #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinerm
approved these changes
Oct 5, 2023
@NicoKiaru I don't know for sure but the expectation that the annotations could be empty for a given |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encounteered a NPE when trying to open an image by using imagej-omero on our omero server. I experienced this issue both in the IDE and within an up-to-date Fiji.
This is a fix that prevents the NPE. The image is then opened fine. This fix prevents the NPE to occur and allows to open the image. But I do not now if it is the right fix: maybe these
omeroAnnotationsshould always be non-empty with the requested pixelsID`. @hinerm what's your opinion on this ?