Add voxelization test and improve voxelization implementation #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kephale
changed the title
ctrueden
added a commit
to imglib/imglib2-mesh
that referenced
this pull request
Sep 29, 2023
And improve the test to make varying the sphere radius simpler. Migrated from imagej/imagej-ops#653. See also imagej/imagej-ops#422. Co-authored-by: Kyle Harrington <[email protected]>
ctrueden
reviewed
Sep 29, 2023
There was a problem hiding this comment.
I am migrating this work to imglib2-mesh; see imglib/imglib2-mesh#7 for the draft.
ctrueden
added a commit
to imglib/imglib2-mesh
that referenced
this pull request
Nov 29, 2023
And improve the test to make varying the sphere radius simpler. Migrated from imagej/imagej-ops#653. See also imagej/imagej-ops#422. Co-authored-by: Kyle Harrington <[email protected]>
gselzer
pushed a commit
to imglib/imglib2-mesh
that referenced
this pull request
Jun 25, 2024
And improve the test to make varying the sphere radius simpler. Migrated from imagej/imagej-ops#653. See also imagej/imagej-ops#422. Co-authored-by: Kyle Harrington <[email protected]>
tinevez
pushed a commit
to imglib/imglib2-mesh
that referenced
this pull request
Aug 29, 2024
And improve the test to make varying the sphere radius simpler. Migrated from imagej/imagej-ops#653. See also imagej/imagej-ops#422. Co-authored-by: Kyle Harrington <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of voxelization could introduce holes in locations where triangles were axis aligned. This PR aims to resolve that and introduce a long needed voxelization test.
The idea here is that the previous version just tested if triangles intersect the center of any given voxel, now we test the corners of the voxel.
This was motivated by this Zulip thread.