Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Proxy issues #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solve Proxy issues #79

wants to merge 1 commit into from

Conversation

frauzufall
Copy link
Member

@frauzufall frauzufall commented Sep 4, 2019

Currently people behind a proxy have issues with updates via HTTPS.

I deleted the rest of the text here because the issue is apparently not in imagej-updater.

@frauzufall frauzufall changed the title HTTPSUtil: Improve HTTPS Check Solve Proxy issues Sep 4, 2019
@frauzufall
Copy link
Member Author

Since the issue seems to be solvable in IJ1 (imagej/ImageJA#17), the only thing left here to do is to catch the SocketException thrown in this case and fall back to HTTP.

@frauzufall frauzufall marked this pull request as ready for review September 10, 2019 20:45
@frauzufall
Copy link
Member Author

frauzufall commented Nov 27, 2019

We discussed somewhere that these changes made to IJ1 to fix the proxy issue should also go to the updater so that a pure IJ2 installation can also deal with proxies.

I am am wondering though how proxy handling in a pure IJ2 environment would work from user perspective.

In IJ1, the HTTP system properties are set via a PlugIn, so we made sure the HTTPS properties are just set to the same value.

In IJ2, if there is no addon like this (or is there?) and one could argue that both HTTP and HTTPS proxy settings have to be set by the user via system properties and don't necessarily have to be the same.

@imagejan
Copy link
Member

imagejan commented Nov 28, 2019

There is OptionsProxy, an IJ2 command that is not shown in the legacy UI.

I guess we might have to somehow sync these options in the legacy layer, if they aren't already.
Of course, they're synced in OptionsSynchronizer, so it might be just enough to ask the OptionsService for the current value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants