-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Jupyter Dynamic Install instructions #317
Conversation
This commit makes a few changes: * Uses "%mamba" over "!mamba" - has support for micromamba * Adds "-c conda-forge" - I found this necessary, at least for micromamba * Adds prefix delimiter manipulation to account for Windows paths
This might be a different issue, but if I write: import sys, os
prefix = sys.prefix.replace("\\", "/") # Handle Windows Paths
%mamba install --yes --prefix {prefix} -c conda-forge pyimagej openjdk=11
os.environ['JAVA_HOME'] = os.sep.join(sys.executable.split(os.sep)[:-2] + ['jre']) and then put in a separate cell: import imagej
ij = imagej.init() I get the following exception:
So there's still barriers to running pyimagej in Jupyter, at least on Windows... |
Thanks for improving this! I'll try this out on the mac, linux and windows machines I have here. You're on Windows 11 right? |
Yes! |
Is there actually a |
This commit fixes how we set the JAVA_HOME variable for PyImageJ in the dynamic install cell. The problem was 2 fold. (1) We were missing a leading slash and (2) did not have platform specific JVM library locations. We may need an additional one for macOS -- this needs further testing.
Thanks @gselzer for improving this and actually getting this to work on all platforms! Looks great to me! |
This commit makes a few changes:
@elevans can you test this out on some other platforms and make sure this works?