Skip to content

Test xarray naming post conversion and enable GUI tests #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Test xarray naming post conversion and enable GUI tests #327

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b50432
Test xarray naming post conversion
gselzer Apr 7, 2025
0376f90
Resolve typo
gselzer Apr 7, 2025
ab2efdc
Run CI test jobs with xvfb
elevans Apr 7, 2025
d5fcb10
Fix fiji stiching test
elevans Apr 8, 2025
b8ee551
Set mode to interactive for tests
elevans Apr 8, 2025
dbf6aaa
Fix ImagePlus sync test
elevans Apr 8, 2025
bd16ac2
Fix dataset conversion linked xarray test
elevans Apr 8, 2025
216d5ae
Force headless mode for tests on macOS
elevans Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/test_legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import numpy as np
import pytest
import scyjava as sj
import xarray

# -- Fixtures --

Expand All @@ -13,6 +14,11 @@ def arr():
return empty_array


@pytest.fixture(scope="module")
def xarr(arr):
return xarray.DataArray(arr, name="test_xarray")


@pytest.fixture(scope="module")
def results_table(ij):
if ij.legacy and ij.legacy.isActive():
Expand Down Expand Up @@ -141,6 +147,19 @@ def test_window_to_numpy_converts_active_image_to_xarray(ij, arr):
assert (arr == new_arr.values).all


def test_linked_dataset_convertsion_to_xarray(ij, xarr):
ensure_legacy_enabled(ij)
Copy link

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'convertsion' in the test function name is misspelled; consider renaming it to 'conversion'.

Suggested change
def test_linked_dataset_convertsion_to_xarray(ij, xarr):
ensure_legacy_enabled(ij)
def test_linked_dataset_conversion_to_xarray(ij, xarr):

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@gselzer gselzer Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you respond to replies? Good catch on the typo, but the suggestion deletes a line that is necessary.

ensure_gui_available(ij)

# get a dataset, linked to an ImagePlus
dataset = ij.py.to_dataset(arr)
ij.ui().show(dataset)

# convert the image data to xarray
xarr_out = ij.py.to_xarray(dataset)
assert xarr_out.name == "test_xarray"


def test_functions_throw_warning_if_legacy_not_enabled(ij):
ensure_legacy_disabled(ij)

Expand Down
Loading