Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable edit link position #290

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Feb 13, 2024

Fix #241 (I followed instructions seen in this conversation)

  • Add a where parameter to editURL
  • Allow user to choose between toc (default) and single
  • Add to single through last-updated partial

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit 712e670
🔍 Latest deploy log https://app.netlify.com/sites/hugo-hextra/deploys/660f03f6377dfd00085de181
😎 Deploy Preview https://deploy-preview-290--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davlgd davlgd force-pushed the davlgd-edit-configurable branch from 9568c1d to 3166be3 Compare February 13, 2024 00:23
imfing
imfing previously approved these changes Feb 13, 2024
Copy link
Owner

@imfing imfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

In addition to the points mentioned earlier, it would be greatly beneficial to include documentation for this new config option.

I'm also open to finish the development of this feature. While it may take a bit longer, I plan to add it into the upcoming minor release.

exampleSite/hugo.yaml Outdated Show resolved Hide resolved
layouts/partials/components/last-updated.html Outdated Show resolved Hide resolved
@imfing imfing dismissed their stale review February 13, 2024 22:58

dismiss

Copy link
Owner

@imfing imfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per above

@davlgd davlgd requested a review from imfing February 14, 2024 00:32
@imfing imfing added this to the v0.8.0 milestone Feb 20, 2024
@imfing imfing added the enhancement New feature or request label Mar 1, 2024
Copy link
Owner

@imfing imfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the styling is broken:

could you update the PR to fix it?

layouts/partials/components/edit-url.html Outdated Show resolved Hide resolved
@davlgd davlgd force-pushed the davlgd-edit-configurable branch from 00f6db1 to 4e2dc7c Compare April 1, 2024 10:42
- Add a `where` parameter to `editURL`
- Allow user to choose between `toc` (default) and `single`
- Add to single through last-updated partial
@davlgd davlgd force-pushed the davlgd-edit-configurable branch from 4e2dc7c to 7ce2252 Compare April 1, 2024 11:21
@davlgd davlgd requested a review from imfing April 1, 2024 11:21
layouts/partials/toc.html Outdated Show resolved Hide resolved
@davlgd davlgd force-pushed the davlgd-edit-configurable branch from 7ce2252 to c09dadf Compare April 1, 2024 15:41
@davlgd davlgd requested a review from imfing April 1, 2024 15:41
layouts/partials/components/edit-url.html Outdated Show resolved Hide resolved
@davlgd davlgd force-pushed the davlgd-edit-configurable branch from c09dadf to 1e19afc Compare April 2, 2024 07:54
@davlgd davlgd requested a review from imfing April 2, 2024 07:55
@imfing
Copy link
Owner

imfing commented Apr 2, 2024

did you update the partial?

@davlgd davlgd force-pushed the davlgd-edit-configurable branch from 1e19afc to 4e29bb5 Compare April 2, 2024 10:31
- `where` > `location`
- Edit link > in a partial
@davlgd davlgd force-pushed the davlgd-edit-configurable branch from 4e29bb5 to f87f19f Compare April 2, 2024 10:31
@davlgd
Copy link
Contributor Author

davlgd commented Apr 2, 2024

Sorry I misunderstood your comment, it should be fixed now

@imfing
Copy link
Owner

imfing commented Apr 2, 2024

Sorry I misunderstood your comment, it should be fixed now

thanks will take a look

layouts/partials/components/edit-url.html Outdated Show resolved Hide resolved
@davlgd davlgd requested a review from imfing April 4, 2024 19:48
@davlgd
Copy link
Contributor Author

davlgd commented Nov 22, 2024

@imfing is it still ongoing or should I close ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "Edit this page" button always visible
2 participants