feat: add configurable edit link position #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davlgd
force-pushed
the
davlgd-edit-configurable
branch
from
9568c1d to
3166be3
Compare
imfing
previously approved these changes
Feb 13, 2024
Owner
imfing
left a comment
imfing
left a comment
There was a problem hiding this comment.
Thank you for the PR!
In addition to the points mentioned earlier, it would be greatly beneficial to include documentation for this new config option.
I'm also open to finish the development of this feature. While it may take a bit longer, I plan to add it into the upcoming minor release.
imfing
requested changes
Mar 31, 2024
davlgd
force-pushed
the
davlgd-edit-configurable
branch
from
00f6db1 to
4e2dc7c
Compare
- Add a `where` parameter to `editURL` - Allow user to choose between `toc` (default) and `single` - Add to single through last-updated partial
davlgd
force-pushed
the
davlgd-edit-configurable
branch
from
4e2dc7c to
7ce2252
Compare
imfing
requested changes
Apr 1, 2024
davlgd
force-pushed
the
davlgd-edit-configurable
branch
from
7ce2252 to
c09dadf
Compare
imfing
requested changes
Apr 1, 2024
davlgd
force-pushed
the
davlgd-edit-configurable
branch
from
c09dadf to
1e19afc
Compare
Owner
|
did you update the partial? |
davlgd
force-pushed
the
davlgd-edit-configurable
branch
from
1e19afc to
4e29bb5
Compare
- `where` > `location` - Edit link > in a partial
davlgd
force-pushed
the
davlgd-edit-configurable
branch
from
4e29bb5 to
f87f19f
Compare
Contributor
Author
|
Sorry I misunderstood your comment, it should be fixed now |
Owner
thanks will take a look |
imfing
requested changes
Apr 3, 2024
Contributor
Author
|
@imfing is it still ongoing or should I close ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #241 (I followed instructions seen in this conversation)
whereparameter toeditURLtoc(default) andsinglesinglethroughlast-updatedpartial