Skip to content

Conversation

@joe128
Copy link

@joe128 joe128 commented Aug 24, 2024

Partial implementation of #444:

Added 2 Params to shortcode card:

  • linktooltip
    Hextra: Tooltip for Link

  • tagtooltip
    Hextra: Tooltip for Tag

open TODOs

  • Add Documentation to fa and zh-cn
  • Maybe Styling in Dark-Mode

@netlify
Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit 69585ee
🔍 Latest deploy log https://app.netlify.com/sites/hugo-hextra/deploys/66ca56b7451c390008a4a2ed
😎 Deploy Preview https://deploy-preview-446--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@imfing imfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joe128 thank you for the PR!

I appreciate the effort you’ve put into this. but I’m not sure if using the title attribute of a link as a tooltip is the best approach.

While allowing users to set a link title for a card is a good idea, I believe we should avoid using title as a tooltip as they serve different purposes.

@joe128
Copy link
Author

joe128 commented Aug 30, 2024

The problem is that there is no "standard" for tooltips but most browsers interpret the title as a tooltip.
So, what do you (@imfing) think about using a "data-tooltip" (HTML data-* Attribute) for the two elements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants