fix: add back empty content filter in search-data.json #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
imfing
commented
Oct 21, 2024
imfing
commented
- this PR reverted the change introduced in feat: show breadcrumbs in search results #473 which causes a nil pointer dereference issue reported in Nil pointer dereference in /json/search-data.json with .File.BaseFileName after upgrading to v0.8.5 #478 and Issue since latest update #481
- will need a reproducible example to investigate the root cause in the future
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jerrytomato
added a commit
to eval-42/theme
that referenced
this pull request
Oct 28, 2024
* fix: add back empty content filter in search-data.json (imfing#482) * Add Hugo Lock File for Example Site * Center Headings Text and Flex Column Items on Home Layout * Explicitly Add Prettier Plugin * Allow Configuring Powered By Link * Use Existing Variable for Powered By Text --------- Co-authored-by: Xin <[email protected]> Co-authored-by: Liam Elliott <[email protected]>
jerrytomato
added a commit
to eval-42/theme
that referenced
this pull request
Oct 28, 2024
* fix: add back empty content filter in search-data.json (imfing#482) * Add Hugo Lock File for Example Site * Center Headings Text and Flex Column Items on Home Layout * Explicitly Add Prettier Plugin * Allow Configuring Powered By Link * Use Existing Variable for Powered By Text --------- Co-authored-by: Xin <[email protected]> Co-authored-by: Liam Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.